Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default maximum size of thumbnailed images #2025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matkoniecz
Copy link

@matkoniecz matkoniecz commented Mar 12, 2025

fixes #2024

note: if it is not autogenerated then docs also need to be manually changed, see https://github.com/search?q=repo%3Alxqt%2Fpcmanfm-qt+4+image+size+limit&type=code&p=3

@matkoniecz
Copy link
Author

I considered bumping it to 400 MB but not sure about potential performance problems

If thumbnailer explodes at processing 20MB photos then it is a thumbnailer bug. Though if it explodes at 350MB files it would be more reasonable (as of 2025).

Likely this limit should be bumped again in a few years. Maybe should be higher already.

@matkoniecz
Copy link
Author

note: this PR is untested

I can try testing it if it will not be flat-out rejected

@tsujan
Copy link
Member

tsujan commented Mar 12, 2025

#2024 (comment)

@matkoniecz
Copy link
Author

#2024 (comment)

@Chiitoo
Copy link

Chiitoo commented Mar 12, 2025

I think the default should stay relatively low, because for one, the space consumed could very much explode without the user realising it.

I'm one of those who does his best with disabling the creation of these files on all the applications I use. : ]

Also as mentioned elsewhere, distributions can change these defaults during packaging, though I think that might also
be unlikely to happen (saying that as one such packager).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Increase default thumbnailer limit as photos nowadays are commonly larger than 4MB
3 participants