Use QRadioButton's in Bulk Rename UI #2029
Open
+97
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, didn't test using it. I wonder if it's possible to add some margin here, before the radiobuttons:
|
|
The margins are moderately better in Fusion: I think for some themes the margins are too narrow because radio buttons are typically inside a group box or otherwise not top-level. |
|
Sorry, but those radio buttons are redundant. The original code already makes the group-boxes exclusive, and I saw no reason to add yet another group-box for the main functionality, exactly because it's the main functionality. |
|
A compromise is made here: #2030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.