Recursively skip verbatim elements #847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles cases like
where a link was embedded in a verbatim block, but embedded in a non-verbatim element (
<span>
).This was correctly handled in html5ever, but not html5gum (which is our default HTML parser in lychee)
Fixes #259 (comment).
@untitaker, is there a better way to handle nested tags in html5gum or would you have resolved the issue in a similar way?