Fold EchAwareDns into AndroidDns - #9645
Merged
Merged
Conversation
swankjesse
commented
Aug 9, 2026
| ShadowNetworkSecurityPolicy::class, | ||
| ], | ||
| ) | ||
| class AndroidDnsRobolectricTest { |
Collaborator
Author
There was a problem hiding this comment.
Renamed from EchAwareDnsTest, and changed a lot!
yschimke
reviewed
Aug 10, 2026
| companion object { | ||
| fun create(dns: FakeDns): Network { | ||
| val result = Shadow.newInstanceOf(Network::class.java) | ||
| Shadow.extract<ShadowNetwork>(result).dns = dns |
yschimke
reviewed
Aug 10, 2026
Collaborator
There was a problem hiding this comment.
sample landed - so will need to update samples/android/src/androidTest/kotlin/okhttp3/sample/ech/EchClientTest.kt
yschimke
reviewed
Aug 10, 2026
| public fun <init> ()V | ||
| public fun <init> (Lokhttp3/Dns;Lokhttp3/Dns;Landroid/security/NetworkSecurityPolicy;)V | ||
| public synthetic fun <init> (Lokhttp3/Dns;Lokhttp3/Dns;Landroid/security/NetworkSecurityPolicy;ILkotlin/jvm/internal/DefaultConstructorMarker;)V | ||
| public fun <init> (Landroid/net/DnsResolver;Landroid/net/Network;Lokhttp3/DnsCache;Z)V |
I don't think each DNS feature should be its own DNS class; instead the single DNS implementation should be configurable. None of these classes have shipped in a stable release, so there's no risk of breaking backwards-compatibility.
swankjesse
force-pushed
the
jwilson.0809.EchAwareDns_fold
branch
from
August 10, 2026 16:46
6763a4f to
1ad1f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think each DNS feature should be its own DNS class; instead the single DNS implementation should be configurable.
None of these classes have shipped in a stable release, so there's no risk of breaking backwards-compatibility.