[not to land] Add Android ECH Testcontainers workflow - #9652
Conversation
18288b8 to
6a87a3a
Compare
|
Failures are expected until ECH retries lands okhttp.android.test.EncryptedClientHelloTest > rejectedConfigIsRetriedWithServerConfig[emulator-5554 - 17] FAILED okhttp.android.test.EncryptedClientHelloTest > rejectedConfigWithoutServerConfigIsRetriedWithoutEch[emulator-5554 - 17] FAILED |
|
I am not a big fan of using containers in OkHttp’s test suite in general, because the tests are slower & flakier than MockWebServer tests. We're in a difficult period for open source. Published libraries are frequently compromised, cascading through publish actions to own developers machines and CI environments. Taking on more transitive deps increases that risk. To be honest I'd rather eject some of our existing dependencies than add more. And I'm further not confident that transitive dependencies will continue to be stable and reliable, in a way I considered them to be last year. Our industry is currently in a mood to prefer velocity over quality. Probably great for certain use cases but not a good fit for a boring foundational library like ours. |
100% vibe coded - for discussion only