[Fix] Code review: bugs, resource leaks, type safety#6
Open
lzmeng02 wants to merge 2 commits into
Open
Conversation
lzmeng02
commented
Jun 2, 2026
lzmeng02
commented
Owner
- Gate DeepSeek-specific params (reasoning_effort, extra_body) on provider, fixing API errors for OpenAI users
- Guard initial scheduleRender on supported route, preventing MutationObserver leak on non-video Bilibili pages
- Add try-catch for getTranscriptForUrl, showing error state instead of permanent loading spinner on network failure
- Return null instead of raw API body on transcript parse failure in normalize
- Reset isCollapsed/isMenuOpen on panel mount to prevent stale UI across SPA navigations
- Call panel cleanup (port, listeners) when navigating away from video pages
- Add sequence counter to subtitle language change to prevent race condition
- Deduplicate ROOT_ID constant (export from dom.ts, import in index.ts)
- Type currentData as PlatformTranscriptResult instead of any
- Remove dead types (GenerationStatus, GenerationResult) and identity function (resolveInitialMode)
- Gate DeepSeek-specific params (reasoning_effort, extra_body) on provider, fixing API errors for OpenAI users - Guard initial scheduleRender on supported route, preventing MutationObserver leak on non-video Bilibili pages - Add try-catch for getTranscriptForUrl, showing error state instead of permanent loading spinner on network failure - Return null instead of raw API body on transcript parse failure in normalize - Reset isCollapsed/isMenuOpen on panel mount to prevent stale UI across SPA navigations - Call panel cleanup (port, listeners) when navigating away from video pages - Add sequence counter to subtitle language change to prevent race condition - Deduplicate ROOT_ID constant (export from dom.ts, import in index.ts) - Type currentData as PlatformTranscriptResult instead of any - Remove dead types (GenerationStatus, GenerationResult) and identity function (resolveInitialMode) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.