feat: env prefix standardization, iframe URL fix & cost optimizer clear#72
Merged
Conversation
…I_* prefix Renames all os.Getenv calls in mc-web-console to follow the MC_<FRAMEWORK>_* prefix convention established in mc-admin-cli PR #30. Key changes: - api/internal/config/config.go: 14 env var renames (DB_*, API_*, GO_ENV, MCIAM_*, MCWEBCONSOLE_MENUYAML, MCADMINCLI_APIYAML, IFRAME_TARGET_IS_HOST) - api/cmd/main.go: JWT_SECRET → MC_WEB_CONSOLE_JWT_SECRET, DB_HOST check → MC_WEB_CONSOLE_POSTGRES_HOST - front/actions/env.go: FRONT_*, API_*, SESSION_SECRET renamed - front/actions/render.go: FRONT_DEV → MC_WEB_CONSOLE_FRONT_DEV - conf/.env.sample: updated to match new variable names Fixes MC_WEB_CONSOLE_MENUYAML and MC_ADMIN_CLI_APIYAML injection (previously these were never injected due to name mismatch — fixes FR-CLOUD-ADMIN-006-08 yaml reachability check). Relates-to: WEB-TECH-001
- Docker 내부 hostname을 브라우저 hostname으로 자동 변환 - localhost 접근 시 http://localhost:PORT 로 변환 (로컬 Docker 환경) - HTTPS 페이지에서 HTTP URL protocol 업그레이드 - trailing slash 제거로 //web/path 이중슬래시 방지
addIframe() appends to existing innerHTML, so the initial warning div persisted even after workspace/project were selected. Clear the container first to ensure a clean state before inserting the iframe.
refactor: standardize env var names to MC_WEB_CONSOLE_* / MC_ADMIN_CLI_* prefix
fix(WEB-BUG-014): iframe 플러그인 URL 정규화 (resolveIframeUrl)
fix(costanalysis): clear #costIframe before loading iframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MC_WEB_CONSOLE_*/MC_ADMIN_CLI_*prefix로 표준화resolveIframeUrl)#costIframe초기화 처리Test plan
MC_WEB_CONSOLE_*/MC_ADMIN_CLI_*prefix 정상 인식 확인