-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure crawlers #47
Conversation
Use decorator to register crawlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ziet er goed uit, heb het zelf nog niet gedraaid maar als het bij jou werkt zal het wel prima zijn. Wat me wel een beetje onduidelijk is, is wanneer enabled_shops
nou daadwerkelijk gevuld wordt - gewoon eenmalig op startup neem ik aan? Kan niet zo goed een duidelijke call vinden die dat doet
Famous last words...
Ja, eenmalig op startup. Iets precieser als je deze import doet:
dan import je |
Fix intergamma crawler, could not be called previously Set sale flag in ah crawler for discounted products Convert price to float in hema crawler Set sale flag in steam crawler for discounted products
522e46f
to
f19d4c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added one minor nitpick. I think it's OK for merge except for one issue: the logger does not seem to work at all on this branch in my testing environment; which is rather odd since you didn't seem to change anything regarding the logger. Is it working for you @tweska?
Logger must be configured before it is called anywhere in the project.
I wrote a decorator to automatically register crawler functions and slightly simplified the crawler code and data structure. I believe this will make adding new crawlers to Argostimè easier for potential new contributors.
This pull request will also close #7 since you can disable shops using the configuration file.
I am currently writing documentation on how to write a new crawler for this version of Argostimè, then we can tick off #32 as well.