-
Notifications
You must be signed in to change notification settings - Fork 464
Added code to add instances into the subclustered placement #4363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RiyaTyagi
wants to merge
3
commits into
sub-cluster-7
Choose a base branch
from
sub-cluster-8
base: sub-cluster-7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following changes have been added with this pull request:
newubclusteredAddInstanceHelper
has been added which checks if the instance already exists in the placement or not. If the instance doesn't exist it assign a subcluster ID to it and then called thenewubclusteredHelper
method. If the instance is already present in the subcluster we check if all the shards of the instance are in leaving state otherwise an error is thrown.addInstance
method has same implementation as present in sharded algorithm with a slight change inassignTargetLoad
method implementation.assignTargetLoad
method we first try to assign shards from the instances belonging to subclusters other than the current adding instance subcluster.