Do not include violations that don't have any offenses #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartpark
force-pushed
the
invisible-offenses
branch
from
8ab66a1 to
e01a226
Compare
stewartpark
force-pushed
the
invisible-offenses
branch
from
e01a226 to
d1a53b6
Compare
|
I'll go ahead and second this PR. We use And can confirm this change fixes our issue. @m4i any chances this will make it in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rubocop-gitcommand exits with exit code 1, but the console output says no offenses.This is because it doesn't display disabled offenses, and if all offenses are disabled under a violation, it just says there are no offenses. But when it determines whether it should
exit(1), it just sees if there are any violations.