Skip to content

Fixed the aspect ratio issue when resizing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smshuja wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the aspect ratio issue when resizing #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions assets/javascripts/app/controllers/element/resizing.module.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ class Resizing extends Spine.Controller

events:
'drag.resize': 'resize'
'start.resize': 'save'
'end.resize': 'save'

constructor: (@element) ->
super(el: @element.el)
Expand Down Expand Up @@ -98,14 +100,14 @@ class Resizing extends Spine.Controller
area.left += position.left

if lockAR
# TODO - FIXME, this doesn't lock AR properly
area.width = Math.max(area.width, area.height)
area.height = area.width
area.width = @area.width * area.height / @area.height

# Make sure we can't have negative widths/heights
area.width = Math.max(0, area.width)
area.height = Math.max(0, area.height)

@element.resize(area)
save: ->
@area = @element.area()

module.exports = Resizing