Skip to content

Conversation

bsergean
Copy link
Collaborator

No description provided.

@awelzel
Copy link
Contributor

awelzel commented May 24, 2025

I had dabbled/hoped to come up with something that would delay the close callback. It'd be great to consume the bytes/frames that are already in the _rxbuf or still buffered in the socket, even if a send failed.

Otherwise, if the client sent a last CLOSE frame or an error indication in a text/binary frame, but then severed the connection, this fix wouldn't allow the server to get to that message. Is that motivation enough for a more complicated fix?

@bsergean
Copy link
Collaborator Author

Other option is to not fail send() the same way when we aren't connected, taking out that early out.

I haven't run the autobahn test for a while btw ... I wonder if those fixes break something or not spec wise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants