Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtaudio: update to 6.0.1 #22286

Closed
wants to merge 2 commits into from
Closed

Conversation

barracuda156
Copy link
Contributor

Description

Update.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@ra1nb0w for port rtaudio.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Jan 20, 2024
@ra1nb0w
Copy link
Contributor

ra1nb0w commented Jan 20, 2024

thank you very much for your contribution. You should also bump the revision of every dependency to be sure that this update doesn't brake anything.

@barracuda156
Copy link
Contributor Author

Sure, will do now.

@barracuda156
Copy link
Contributor Author

@ra1nb0w Do you know if it is our issue or SoapyAudio upstream one?

  /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_science_SoapyAudio/SoapyAudio/work/SoapyAudio-0.1.1/Streaming.cpp:242:14: error: unknown type name 'RtAudioError'; did you mean 'RtAudioErrorType'?
      } catch (RtAudioError& e) {
               ^~~~~~~~~~~~
               RtAudioErrorType
  /opt/local/include/rtaudio/RtAudio.h:228:6: note: 'RtAudioErrorType' declared here
  enum RtAudioErrorType {
       ^
  /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_science_SoapyAudio/SoapyAudio/work/SoapyAudio-0.1.1/Streaming.cpp:243:60: error: member reference base type 'RtAudioErrorType' is not a structure or union
          throw std::runtime_error("RtAudio init error '" + e.getMessage());
                                                            ~^~~~~~~~~~~

P. S. The second dependent of rtaudio is pointless to add into CI, it is badly broken for unrelated reasons. https://trac.macports.org/ticket/69136

@barracuda156
Copy link
Contributor Author

barracuda156 commented Jan 20, 2024

Okay, it is not ours:
mltframework/mlt#930
AlexandreRouma/SDRPlusPlus#1153

UPD. There is an issue with upstream, ignored since September: pothosware/SoapyAudio#21

@ra1nb0w Should we just close this? No one gonna die if rtaudio stays outdated.

@barracuda156
Copy link
Contributor Author

Let me close it now to ease PR queue; if upstream fixes the breakage, we can reopen it, rebase and merge.

@ra1nb0w
Copy link
Contributor

ra1nb0w commented Jan 20, 2024

It is not an issue of rtaudio since it is a major release. The rtaudio's developers can change whatever they want and it is reported on the release changelog. The applications that are using rtaudio need to update their code and use the new error handling. For the moment we can stay as is since it works fine and the new release seems doesn't provide nothing too useful.

Anyway, thank you very much for your interest. Feel free to open a new PR when everything is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
Development

Successfully merging this pull request may close these issues.

3 participants