Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoc @10.2.0 Warning: invalid escape sequence '\S' #25780

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

christophecvr
Copy link
Contributor

@christophecvr christophecvr commented Sep 17, 2024

asciidoc: Update to 10.2.1

Closes: https://trac.macports.org/ticket/70039

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.7
Xcode 11.5 / Command Line Tools 11.5.0
Compiler Apple clang 11.0.1

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@neverpanic for port asciidoc.

@ryandesign
Copy link
Contributor

I assume you meant macOS 10.15.7?

When we merge this (or beforehand by force-pushing if you wish) we should reword the commit message to remove the square brackets around the URL.

@ryandesign
Copy link
Contributor

The first line of the commit message should also be reworded to say "asciidoc: Update to 10.2.1"

@christophecvr
Copy link
Contributor Author

christophecvr commented Sep 17, 2024

I assume you meant macOS 10.15.7?

When we merge this (or beforehand by force-pushing if you wish) we should reword the commit message to remove the square brackets around the URL.

Yes corrected to 10.15.7

The commit message self can't be edited, but I updated the message here
First line update to asciidoc: to 10.2.1
and the link here Fixes : [...] is removed

Closes: link set instead.

p.s. I well can just create a commit just to have a new message on top but then it becomes a messy pot (I find)
However now I know that by the initial commit the msg created with the git vi editor does not need brackets for the link.
So I know it for next time. 👍

@ryandesign
Copy link
Contributor

Changing the text of the PR isn't relevant. The commit message can be edited. Then you force push. Or we can edit the message when we merge the PR.

@christophecvr
Copy link
Contributor Author

@ryandesign
Would this be the perfect commit initial message created with vi editor perfect ?
Since I did not commit the change to my personal work branch in my github fork of macports.
I took the opportunity to test it.

For just this last patch update asciidoc: to 10.2.1
example

@markemer
Copy link
Member

Should we recommend asciidoctor as that has replaced this as Asciidoc's reference implementation?

@christophecvr
Copy link
Contributor Author

christophecvr commented Sep 18, 2024

Should we recommend asciidoctor as that has replaced this as Asciidoc's reference implementation?

This is asciidoc-py not asciidocter . asciidocter also a converter but is another utility. aciidoctor has also a port.

The git hub has been moved from :

https://github.com/asciidoc/asciidoc-py3

to :

https://github.com/asciidoc-py/asciidoc-py

@christophecvr
Copy link
Contributor Author

Changing the text of the PR isn't relevant. The commit message can be edited. Then you force push. Or we can edit the message when we merge the PR.

Ok sorry forgot about the git amend followed by forced push. Is just done now

@neverpanic neverpanic merged commit 145b755 into macports:master Sep 19, 2024
3 checks passed
@christophecvr christophecvr deleted the asciidocupg branch September 20, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants