Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost181: Install Boost CMake find scripts by default #25818

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

mvieth
Copy link
Contributor

@mvieth mvieth commented Sep 18, 2024

Description

CMake transitions more and more towards using Boost's BoostConfig.cmake, which is only installed if the option --no-cmake-config is not given. The documentation of the variant also mentions that these CMake scripts should be installed by default.
See also https://cmake.org/cmake/help/latest/module/FindBoost.html

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

Unfortunately, I have no macOS available to test this on. I would argue that, since I am effectively turning the variant on by default, the risk of this change is small.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port boost181.
@michaelld for port boost181.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Sep 18, 2024
@barracuda156
Copy link
Contributor

This is indeed desirable, see: pika-org/pika#1236

@mvieth
Copy link
Contributor Author

mvieth commented Nov 20, 2024

@mascguy @michaelld Friendly ping. Would be great if you could review this. Thanks in advance!

Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, completely forgot about this PR. Thanks for the reminder, aa well as the contribution!

@mascguy
Copy link
Member

mascguy commented Nov 20, 2024

P.s. Oh, you need to rev-bump the port too

@mascguy mascguy merged commit 7269491 into macports:master Nov 20, 2024
2 of 3 checks passed
@mvieth mvieth deleted the patch-1 branch November 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

5 participants