Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-wxpython-4.0: add py313 subport, patch for py-sip 6.10.0 #27613

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 9, 2025

Description

py-wxpython-4.0: add py313 subport, patch for py-sip 6.10.0

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.7.2 23H311 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change please, and is the patch from upstream or something you put together? In either case please provide a link to the upstream commit or PR.

port:py${python.version}-six \
port:py${python.version}-sip \
port:py${python.version}-pathlib2
port:py${python.version}-pillow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be capitalized correctly so that it will work on case-sensitive file systems as well:

port:py${python.version}-Pillow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separated the sip patch and included link to upstream fix (the link was previously only in commit message), and changed to Pillow.

@reneeotten reneeotten merged commit 8a9ee33 into macports:master Feb 12, 2025
3 checks passed
@nilason
Copy link
Contributor Author

nilason commented Feb 12, 2025

Thanks!

@nilason nilason deleted the wxpython branch February 13, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants