Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhyme: update fatalError signature #27620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ylluminarious
Copy link
Contributor

@ylluminarious ylluminarious commented Feb 10, 2025

Description

This pull request updates the fatalError function signature in the rhyme port. Previously, setup.h declared

void fatalError(char s[]);

while setup.c defined it as

void fatalError(const char *s) { … }

This inconsistency caused a build error on macOS 15.3 when fatalError was passed to gdbm_open (which expects a function pointer taking a const char *). Changing the declaration in setup.h to use const char * brings both files into alignment and resolves the conflict. The port revision has been bumped to 7 accordingly.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.3 24D60 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Raimondi for port rhyme.

@reneeotten
Copy link
Contributor

@ylluminarious did you submit this patch upstream (or is it an upstream patch?); in either case please provide a URL in the patchfile that points to the upstream issue/PR/commit.

@ylluminarious
Copy link
Contributor Author

@reneeotten I did not because the program has not been updated for 12 years: https://sourceforge.net/projects/rhyme/

It therefore seems unlikely that any upstream patches will be accepted anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants