rhyme: update fatalError signature #27620
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
fatalError
function signature in the rhyme port. Previously,setup.h
declaredvoid fatalError(char s[]);
while setup.c defined it as
void fatalError(const char *s) { … }
This inconsistency caused a build error on macOS 15.3 when
fatalError
was passed togdbm_open
(which expects a function pointer taking aconst char *
). Changing the declaration insetup.h
to useconst char *
brings both files into alignment and resolves the conflict. The port revision has been bumped to 7 accordingly.Type(s)
Tested on
macOS 15.3 24D60 arm64
Xcode 16.2 16C5032a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?