Change the cancel context to be per runner#59
Merged
Conversation
ispasov
force-pushed
the
is/cancel-per-runner
branch
2 times, most recently
from
1b07575 to
4a7eeb4
Compare
relwell
approved these changes
Feb 19, 2026
Previously jobs were tied to runners, so when a job completes, we cancelled the runner context. Job and runner were assigned during the provisioning process. However, it is possible that a job is taken from another runner. In this case when the job completes the integration cancels the context for the wrong runner. To make sure this does not happen, use the runner name to cancel the context and not the job id.
ispasov
force-pushed
the
is/cancel-per-runner
branch
from
4a7eeb4 to
d5c4c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously jobs were tied to runners, so when a job completes, we cancelled the runner context. Job and runner were assigned during the provisioning process.
However, it is possible that a job is taken from another runner. In this case when the job completes the integration cancels the context for the wrong runner. To make sure this does not happen, use the runner name to cancel the context and not the job id.