Skip to content
This repository was archived by the owner on Nov 15, 2019. It is now read-only.

Conversation

@romain-jacquart
Copy link

As of PHP 7.2, get_class() parameter can not be null.

This PR adds a simple null check before using get_class().

@GromNaN
Copy link

GromNaN commented Jun 28, 2019

Hello @Anahkiasen this small fix makes your library compatible with PHP 7.2.

@Anahkiasen
Copy link
Member

I'm sorry, the package is abandoned in favor of Spatie's. We indicated it on Packagist but not in the repository yet, we'll update the README to reflect this.

@GromNaN
Copy link

GromNaN commented Jun 29, 2019

This is totally fine to want to stop maintaining a package and thank you for pointing to an alternative, unfortunately it is not compatible with PHP 5.6.
We are upgrading a project from PHP 5.6 to 7.2. We makes an heavy usage of your snapshot library and we have to keep these tests to validate the upgrade.
Our code must be compatible with both PHP versions during several weeks. We will eventually switch to spatie/phpunit-snapshot-assertions later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants