Fix VectorIndex upsert behavior - #75
Closed
mspandey wants to merge 1 commit into
Closed
Conversation
## Summary Fix VectorIndex upsert behavior to update existing documents instead of always inserting duplicates. ## Changes Made * Added lookup logic before inserting documents. * Updated existing entries when a document with the same screenshot ID already exists. * Preserved insertion behavior for new documents. ## Why This Change? The `upsert` method currently appends every document to the internal collection, even when an entry with the same identifier already exists. This can lead to duplicate records and inconsistent index state. Implementing true upsert behavior ensures existing documents are updated while new documents are inserted only when necessary. ## Impact * Prevents duplicate entries in the vector index. * Aligns implementation with the expected semantics of an upsert operation. * Improves consistency of stored screenshot analysis records.
|
🎉 Thanks for submitting a PR, @mspandey! Please confirm the following checklist before review:
A maintainer will review your PR shortly. Thank you! 🚀 |
Owner
|
ESOC or SSOC ? and please read contribution guidlines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix VectorIndex upsert behavior to update existing documents instead of always inserting duplicates.
Changes Made
Why This Change?
The
upsertmethod currently appends every document to the internal collection, even when an entry with the same identifier already exists. This can lead to duplicate records and inconsistent index state.Implementing true upsert behavior ensures existing documents are updated while new documents are inserted only when necessary.
Impact
Summary: Describe your changes
Issue ticket number and link
Closes #
Changes
Testing
Checklist before requesting a review
.envvalues are committed