You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just wanted to monitor usage of highWaterMark of transforms, which is able to be seen in Node 9.4.0, inside the function "ontransform", and I couldn't. Because currently "parallel-transform" depends on a third party "readable-stream".
Not the maintainer of this package, but readable-stream is a stable stream base unlike the node core streams package which changes depending on which version of node you are using. It gives someone extending streams a stable base to work on instead of worrying about missing functionality and polyfills etc.
Node 9 and 10 changes will land in readable-stream in the next major release v3, which has a PR open, and should be released relatively soon. I'm guessing @mafintosh will update this package with the new version after it is released.
You should note that 8 is the latest LTS and thus many packages are still catching up to 9 and especially 10 features :)
Also, changing to a class makes ParallelTransform() without new not work. So this would be a semver-major change with the only benefit being modernised syntax and slightly faster support for newer additions to the streams module :)
@Tapppi Sorry for my late reply, I noticed but forgot to make a comment.
Thank you for telling me that. So for the two reasons, it seems we should not erase readable-stream deps from parallel-transform. I'll close this PR, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great module.
I just wanted to monitor usage of highWaterMark of transforms, which is able to be seen in Node 9.4.0, inside the function "ontransform", and I couldn't. Because currently "parallel-transform" depends on a third party "readable-stream".
Why don't we switch it now?