Skip to content

Conversation

adarshkhatri
Copy link

Preconditions (*)

  1. magento/module-inventory-cache
  2. Magento 2.4.7-p2

What is happening?

MSI has this function in place as around method. Which gets the product IDs from inventory_stock_ID table before and after.
Pay attention to around method here.

public function aroundExecuteList(Sync $subject, callable $proceed, array $stockIds)

Then, it also has this function as after method to index grouped products, which happens after the above function (around) runs, meaning at this time, the system has already sent all the grouped product IDs to clear the cache.

What this means?

If I have 200 grouped products in my system, every time a single product's (not related to grouped whatsoever) sources deleted/added, then it will send the cache clear request for this product PLUS that 200 grouped products.

Steps to reproduce (*)

  1. Make sure you have some grouped products
  2. Run bin/magento indexer:reindex inventory

Expected result (*)

  1. System should only send impacted products to clear the cache

Actual result (*)

  1. System should never send unrelated product to clear the cache

@engcom-Hotel
Copy link
Collaborator

Hello @adarshkhatri,

Thanks for your contribution!

We request you to please sign the CLA and resolve the conflicts of this PR, so that we can proceed with this PR. Meanwhile we are moving this PR On hold.

Thanks

@adarshkhatri
Copy link
Author

I see there is a bigger piece of change. Perhaps that is addressing the same issue, but I cannot confirm that atm.

@engcom-Hotel
Copy link
Collaborator

In that case, I think we should close this PR.

Please suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants