fix: log exceptions during source distance calculation #3422
Conversation
|
@magento run all tests |
There was a problem hiding this comment.
Pull Request Overview
This PR adds error logging to the source distance calculation functionality in the In Store Pickup module. When an exception occurs during address-to-coordinates conversion, it will now be logged instead of silently failing.
- Adds logging of
LocalizedExceptionduring source distance calculation - Introduces
LoggerInterfacedependency injection with fallback toObjectManager
| /** | ||
| * @param GetLatsLngsFromAddressInterface $getLatsLngsFromAddress | ||
| * @param GetOrderedDistanceToSources $getOrderedDistanceToSources | ||
| * @param AddressInterfaceFactory $addressInterfaceFactory | ||
| * @param Pipeline $searchTermPipeline | ||
| * @param Logger $logger |
There was a problem hiding this comment.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Hello @SamJUK,
Thanks for the contribution!
Please look into the below review comments. And also check the review comments made by the Copilot.
The failed tests seems flaky to me, will re-run to be double sure.
Thanks
| */ | ||
| public function __construct( | ||
| GetLatsLngsFromAddressInterface $getLatsLngsFromAddress, | ||
| GetOrderedDistanceToSources $getOrderedDistanceToSources, | ||
| AddressInterfaceFactory $addressInterfaceFactory, | ||
| Pipeline $searchTermPipeline | ||
| Pipeline $searchTermPipeline, | ||
| LoggerInterface $logger |
There was a problem hiding this comment.
$logger should be null by default
| LoggerInterface $logger | |
| LoggerInterface $logger=null |
|
@magento run Functional Tests B2B, Functional Tests CE, Integration Tests, Static Tests, Unit Tests |
Log exceptions encountered during In Stock Pickup source distance calculation instead of silently discarding them.
Fixes: #3420