FixFor#40209 - Conditional TotalCollect Trigger for mutation and Virtual Carts

[senthilengg]

Description (*)

• Trigger CollectTotals only if the below condition are true
• Quote is not virtual
• Check GraphQl ResolverInfo OperationType is not "query"

Related Pull Requests

https://github.com/magento-gl/magento2ee/pull/713

Fixed Issues (if relevant)

1. Fixes Cart Query >> CartPrice GraphQl Performance Optimisation #40209

Manual testing scenarios (*)

1. Include CartPrice in Cart Graphql
2. Also test all cart mutations

Questions or comments

1. Similar GraphQl context check can be used in other areas to make the api's faster

[m2-assistant]

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ct-prd-pr-scan]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

[senthilengg]

@magento run Unit Tests

[senthilengg]

@magento run Unit Tests

[senthilengg]

@magento run Database Compare,Functional Tests CE,Functional Tests EE,Functional Tests B2B,Integration Tests,Magento Health Index,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B,Static Tests,WebAPI Tests,Semantic Version Checker

[senthilengg]

@magento run Static Tests

[senthilengg]

@magento run WebAPI Tests

[senthilengg]

Resolved conflicts and Copyright format updated.

[engcom-Dash]

@engcom-Hotel, please review this PR. I’ve fixed the Web API failure issue, so we can proceed with the further process for this PR.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @senthilengg

Thanks for the contribution!

✔️ QA Passed

Preconditions:
Install fresh Magento 2.4-develop

Manual testing scenarios

1. Created a large number of simple products.
2. Applied a Cart Price Rule to the created products.
3. Added multiple products to the cart.
4. Fetched the cart price with discount.

Execution Time: 1320 ms

5. Fetched the cart price without discount.

Execution Time: 578 ms

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Dash]

@magento run Integration Tests, WebAPI Tests, Functional Tests EE, Functional Tests B2B

[senthilengg]

@engcom-Dash this PR avoid loading totals for cart.prices you have tested with cart.items.prices which still triggers collect totals.

I have fixed cart.items.prices total load separately in #40289

[engcom-Dash]

@engcom-Dash this PR avoid loading totals for cart.prices you have tested with cart.items.prices which still triggers collect totals.

I have fixed cart.items.prices total load separately in #40289

@senthilengg I have updated the above testing steps

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests, Functional Tests EE, Functional Tests B2B, Functional Tests CE

[engcom-Dash]

@magento run Unit Tests, Functional Tests EE, Functional Tests B2B, Functional Tests CE

[engcom-Dash]

The consistent failures in Functional CE, B2B,EE are known issues and JIRA is open for the same. The other failures are inconsistent and flaky. They neither part of the PR nor failing because of the PR changes.

CE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/fb89a039f128d79d20584020975d49df/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/2686a73cb88180ec32e045cfcaab89e0/Functional/allure-report-ce/index.html#categories/7c91e0ce9ab9dfaa9671d4f8bce7d3a9/cfa775b876566f16/

B2B
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/bd80158a875192f5661f92ca784608e4/Functional/allure-report-b2b/index.html#categories/ed16d1362a7a61c31a1f41ef937defb9/6f838a50b1569a59/

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/b7fd8b1c174d533555713f7c7ecdf68f/Functional/allure-report-b2b/index.html#categories/ed16d1362a7a61c31a1f41ef937defb9/bb12e097d07cbd0a/

EE
Build 1
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/f5af563716f578dcb9b22b696e693dda/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40224/81c7998a6e984e5b813b51de87f71745/Functional/allure-report-ee/index.html#categories

Known Issue
CheckProductsAfterUpdateDeleteStagingTestACQE-8667
AdminSearchCustomerAddressByKeywordTestACQE-8945

Hence, Moving this PR to Merge In Progress