Skip to content

fix: add export name input - #1627

Open
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/export-name-input-1282
Open

fix: add export name input#1627
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/export-name-input-1282

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Closes #1282.\n\nAdds a custom export name field in the export settings panel, sanitizes the value for safe filenames, and uses it to seed the final download/share filename.\n\nValidation:\n- node node_modules/typescript/bin/tsc --noEmit\n- node node_modules/vitest/vitest.mjs run src/lib/tests/fileNaming.test.ts\n- git diff --check

@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:testing Testing labels Jul 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @saurabhhhcodes

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@magic-peach

Copy link
Copy Markdown
Owner

Hi @saurabhhhcodes — thanks for this, and sorry for the wait.

I'd like to get this merged, but it replaces a cn() call with a template literal, which loses Tailwind class-conflict resolution.

To get it unblocked:

  1. restore the cn() wrapper on those className props

Could you take a look within the next 14 days? If I don't hear back by then I'll close it to keep the queue manageable — but you're very welcome to reopen it any time after that. Thanks again for contributing to Reframe 🙏

@magic-peach magic-peach added the status:changes-requested Maintainer asked for a specific fix label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts status:changes-requested Maintainer asked for a specific fix type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GSSoC] Feature Request: Add Custom Project/Export Name Input Field

2 participants