Skip to content

feat: Improvements from audit feedback #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Apr 2, 2025

Description

This PR includes changes based on suggestions that arose from the delegation program audit.

  • Use upgrade authority instead of a hardcoded admin key
  • Add a comment specifying that process_init_protocol_fees_vault is a permissionless instruction
  • Remove the mocked verify_state; added a comment noting that state validation is currently based on whitelisting in the program

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@GabrielePicco GabrielePicco merged commit 284d02e into main Apr 2, 2025
3 checks passed
@GabrielePicco GabrielePicco deleted the chore/improvements-from-audit-feedback branch April 2, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant