Skip to content

feat: add helper method to turn DelegateAccountMetas struct into a vec #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bmuddha
Copy link
Contributor

@bmuddha bmuddha commented Mar 28, 2025

No description provided.

@bmuddha bmuddha requested a review from GabrielePicco March 28, 2025 07:46
@bmuddha bmuddha self-assigned this Mar 28, 2025
account_signer_seeds: Vec<Vec<u8>>,
) -> ProgramResult {
if !buffer.is_signer {
pub fn undelegate_account(accounts: UndelegateAccounts, pda_seeds: Vec<Vec<u8>>) -> ProgramResult {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement in the API, but it breaks the generate_undelegate() of the ephemeral macro, we should also change it there

Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should also change the undelegate_account in the ephemeral macro. undelegate_account It's gonna be a breaking change, so we should bump the SDK version and run ./version_align script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants