-
Notifications
You must be signed in to change notification settings - Fork 14
feat: committor service #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
45bdf72
test: add realloc ix to flexi counter
thlorenz 2e61882
chore: resort workspace depencencies
thlorenz 6806acf
chore: retire old remote scheduled commits processor and add new one
thlorenz 8cdc141
feat: initial impl of commits processor based on committor service
thlorenz c0d08a4
feat: initializing committor service at startup
thlorenz 9eed608
test: logging signature of failed init_committees tx
thlorenz dae8ea8
test: adapt to expect two signatures when finalizing
thlorenz 80e6777
feat: ensure ephemeral validator is funded on chain
thlorenz 3078a1c
test: add single account commit test
thlorenz 8391124
test: warn when we have issues fetching a transaction
thlorenz e5aa347
fix: adding change for validator fund check
thlorenz be98740
feat: fully integrating committor service
thlorenz 5ce7a20
chore: update ix tests cargo
thlorenz b54cd3b
chore: comment with requirements for schedule commit tests
thlorenz dc2da58
chore: improve test logs
thlorenz 560fd6b
chore: include compute unit price when initializing committor
thlorenz b3445c1
fix: mark accounts to be undelegated
thlorenz 24bb27a
chore: properly handle some unwraps
thlorenz cc389e7
test: general improvements + fixes
thlorenz f7304cf
chore: use trait for committor service and create stub to use in tests
thlorenz 04b0116
chore: update ensure accounts tests to use stub
thlorenz d770b95
chore: re-enable account cloner and ensure accounts tests
thlorenz 88dd40b
chore: move committor repo crates into magicblock monorepo
thlorenz e6f1edd
chore: move committor service integration tests
thlorenz 1c4dd78
chore: noting escrow/fee payer related test requirements
thlorenz 8c620fe
chore: minor cleanup in test runner
thlorenz f3e17d1
ix: load committor program for schedule commits
thlorenz 6d109f9
ix: allow configuring loaded accounts
thlorenz 0dceb8b
ix: match ephem validator keypair to the one we use on chain
thlorenz 7fdc795
ix: ensure we always pass same loaded chain accounts to chain + ephen…
thlorenz 47ccee4
ix: update dlp binary
thlorenz c85b529
ix: add committor tests to run_tests
thlorenz cf609d4
ix: move table mania tests to integration
thlorenz b968ea5
ix: run table mania as part of test suite
thlorenz d3bacca
Merge branch 'master' into thlorenz/committor
thlorenz 7bde596
chore: fmt
thlorenz 52fd831
chore: update delegation program reference
thlorenz 714dd68
chore: opt out of doctests for added crates
thlorenz 0f94802
ix: add rule to make committor program
thlorenz c8ddb16
fix: error misspelling
thlorenz b246170
chore: address some greptiles
thlorenz d3892d1
ix: check in missing config
thlorenz ca5e9f4
chore: more greptiles
thlorenz bc48d58
ix: move table mania/committor tests last since they are the slowest
thlorenz 9fb082a
chore: rollback delegation program version
thlorenz ee396da
chore: cleanup stray log
thlorenz 8635738
ix: give more compile time before expecting validator to listen
thlorenz 7f3e0eb
chore: greptiles
thlorenz 28504c1
chore: improved error handling in table mania manager
thlorenz bc1324d
fix: greptiles
thlorenz 644ad1c
chore: demote some no longer urgent TODOs
thlorenz 4f8ecc8
feat: committor service persists into ledger path
thlorenz 3cf473d
chore: remove duplicate code in magic validator
thlorenz a7b4aa5
feat: limiting stale reallocs until we bail
thlorenz 776bbf1
tmp: disabling ledger restore tests to isolate issues
thlorenz aeeb5ae
tmp: disable all workflows but integration tests while isolating issues
thlorenz aedf9a2
fix: ordering of worker startups
thlorenz 1e9921d
Revert "tmp: disabling ledger restore tests to isolate issues"
thlorenz 0e0ef0f
Revert "tmp: disable all workflows but integration tests while isolat…
thlorenz 2bfd49f
chore: address nits
thlorenz 05bbaec
Merge branch 'master' into thlorenz/committor
thlorenz 4d1b44f
chore: update cargo lock files
thlorenz 9e091fc
chore: match mdp version
thlorenz 263ade9
Merge branch 'master' into thlorenz/committor
thlorenz 67b98bd
Merge branch 'master' into thlorenz/committor
GabrielePicco 9ee833d
chore: move can_clone method to clone permissions itself
thlorenz 8610bce
feat: only launch committor service if we aren't in offline mode
thlorenz 10bdf51
chore: update committor program id
thlorenz 2e99570
Merge branch 'master' into thlorenz/committor
thlorenz d594ba8
chore: use up todate tmpdir method to keep directory
thlorenz ff313fd
chore: remove obsolete DecoderError impl
thlorenz 088be94
chore: disable type complexity warning
thlorenz 7a725ae
ix: allow specifying integration tests to run
thlorenz 1ab5d7e
feat: log amount of accounts we tried to commit when it fails
thlorenz cd219cc
test: printing script to start test validator for specific setup
thlorenz c0eec86
test: reproduced committor service issue of too large tx in ix test
thlorenz fe9860f
fix: wrongful combination of multiple bundles into single changeset
thlorenz c52cf0e
fix: run all tests when RUN_TESTS is not set
thlorenz b34ed17
chore: track reserve pubkeys time via initiated field
thlorenz 6d35f9e
fix: handle async committor actor msgs on separate tasks to not block…
thlorenz a84707c
feat: table mania determine CUs via test
thlorenz 8b89125
chore: various fixes
thlorenz 27dd1d8
feat: compute budget instructions for create + extend
thlorenz 59f8edf
chore: remove obsolete lookup_table.rs
thlorenz edb7a06
feat: include compute budget instructions for deactivate/close table
thlorenz 6a583c9
feat: start reserving pubkeys before clone operation for perf
thlorenz c8e4435
fix: error spelling
thlorenz 6449d59
feat: gert tx information when committor service fails in account cloner
thlorenz 92d5487
fix: ix tests using old lookup table
thlorenz 1b51fc6
chore: table mania ix test logs logs and CUs used
thlorenz d7a3c1f
fix: adjust compute budget (+300 CUs for compute budget ixs)
thlorenz 179091e
fix: lookup table update extend signatures
thlorenz d5366f3
fix: most issues in table mania ix tests
thlorenz 2fde756
chore: update max extend pubkeys due to added budget ixs
thlorenz 7ce2319
feat: close returns sig
thlorenz d5a69ca
chore: update close test and usage
thlorenz 0f2cee6
chore: enable mb api test harness
thlorenz e4db119
test: don't crash if init transaction is not found
thlorenz c636d25
feat: allow skipping tests in test-runner
thlorenz 63736eb
nit: correct poison error message
thlorenz 115bfe4
fix: assertion ensuring all pubkeys are present in table
thlorenz 78073ed
fix: method renaming in ix tests
thlorenz 2fc16f5
chore: improve debug assertion for extension issue
thlorenz b6b58ab
fix: ensuring all stored keys are in table
thlorenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: we now have services ending with
committor
andcommitter
, likeRemoteAccountCommitter
.committor
must be a typoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, everything in the committor-service is committor.
RemoteAccountCommitter
existed before.It's a solana thing as we are buildooors. I'm trying to keep our codebase fun :)