Special case for "fat" ledger. Use compaction + CompactionFilter #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taco-paco
requested review from
thlorenz,
GabrielePicco,
bmuddha and
Dodecahedr0x
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+258
to
+260
| pub fn set_oldest_slot(&self, slot: Slot) { | ||
| self.oldest_slot.store(slot, Ordering::Relaxed); | ||
| } |
There was a problem hiding this comment.
logic: using Ordering::Relaxed here could lead to inconsistencies in a multi-threaded environment. Consider using Ordering::SeqCst for slot threshold changes
| @@ -20,6 +21,7 @@ use crate::{ | |||
| pub const DEFAULT_TRUNCATION_TIME_INTERVAL: Duration = | |||
| Duration::from_secs(2 * 60); | |||
| const PERCENTAGE_TO_TRUNCATE: u8 = 10; | |||
| const FILLED_PERCENTAGE_LIMIT: u8 = 100 - PERCENTAGE_TO_TRUNCATE; | |||
|
|
|||
| struct LedgerTrunctationWorker<T> { | |||
There was a problem hiding this comment.
syntax: Typo in struct name: 'LedgerTrunctationWorker' should be 'LedgerTruncationWorker'
Suggested change
| struct LedgerTrunctationWorker<T> { | |
| struct LedgerTruncationWorker<T> { |
taco-paco
force-pushed
the
fix/ledger/delete-using-compaction-filter
branch
from
f1ba00e to
ee5d428
Compare
taco-paco
force-pushed
the
fix/ledger/delete-using-compaction-filter
branch
from
37dc7a1 to
a5cda6f
Compare
bmuddha
approved these changes
Jul 4, 2025
| @@ -111,71 +111,74 @@ pub fn init_commit_accounts_ticker( | |||
| }) | |||
| } | |||
|
|
|||
| #[allow(unused_variables)] | |||
There was a problem hiding this comment.
why not delete the method altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining CompactionFilter + ManualCompaction.
Greptile Summary
Implements an optimized cleanup mechanism for large ('fat') ledgers by combining RocksDB's CompactionFilter with manual compaction processes for efficient data purging.
PurgedSlotFilterFactoryindatabase/cf_descriptors.rsto automatically filter old slots during compactionoldest_slottracking indatabase/rocks_db.rsto safely manage data retention thresholdsget_lowest_slot()andset_lowest_cleanup_slot()instore/api.rsto coordinate manual deletion with automatic compactiontruncate_fat_ledgermethod inledger_truncator.rswith performance measurements for compaction operations