-
Notifications
You must be signed in to change notification settings - Fork 15
Change account layout #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
87a0614
to
034fee7
Compare
1. reuse slack space which is available in block allocation if possible, this avoids reallocation of accounts if the data field grows insignificantly. 2. track account owner change to avoid index checks in happy path
c5951a2
to
9ca8678
Compare
GabrielePicco
approved these changes
Jul 14, 2025
thlorenz
added a commit
that referenced
this pull request
Jul 23, 2025
* master: Special case for "fat" ledger. Use compaction + CompactionFilter (#413) feat: make eager lookup table preparation configurable (#470) feat: improve lookup table overhead for cloning pipeline (#457) feat: CLI configuration (#447) Track delegation status (#452) Change account layout (#451) fix: prevent new subscriptions if no free connections exist (#456) chore: avoid CU budget exceeded for lookup table management (#455)
thlorenz
added a commit
that referenced
this pull request
Jul 24, 2025
* master: Special case for "fat" ledger. Use compaction + CompactionFilter (#413) feat: make eager lookup table preparation configurable (#470) feat: improve lookup table overhead for cloning pipeline (#457) feat: CLI configuration (#447) Track delegation status (#452) Change account layout (#451) fix: prevent new subscriptions if no free connections exist (#456) chore: avoid CU budget exceeded for lookup table management (#455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify account layout in accounts database:
this avoids reallocation of accounts if the data field grows
insignificantly.
depends on #419
closes #443
closes #441
Greptile Summary
Major refactoring of AccountsDB storage and indexing system to optimize account data storage and improve performance through block space reuse and owner tracking.
Table
abstraction inmagicblock-accounts-db/src/index/table.rs
for better database operation encapsulationmagicblock-accounts-db/src/lib.rs
to reuse slack space in block allocations, reducing unnecessary reallocations for small data growthmagicblock-accounts-db/src/index/iterator.rs
by removing manual cursor management