-
Notifications
You must be signed in to change notification settings - Fork 19
feat: support helius laser GRPC client for cloning #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
47cedac
77e6cab
f48da9b
a4f0e07
5aac783
f529c5f
d0311b4
81f8abc
d4135af
0ba9501
39d2af8
c2f1e33
b667331
0899746
aa0c8b8
ba3580b
c5bc16e
c76a66d
500ebc0
508bf98
4bc1d53
df5aaf5
e85f603
7e9510e
6cf4f72
9e06ee4
775ca4a
c763599
c78772e
ed09009
56215a1
3cf8f13
d3f293a
be27ee7
c0741de
e646942
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,8 +17,8 @@ use crate::{ | |||||
| config::ChainlinkConfig, | ||||||
| fetch_cloner::FetchAndCloneResult, | ||||||
| remote_account_provider::{ | ||||||
| ChainPubsubClient, ChainPubsubClientImpl, ChainRpcClient, | ||||||
| ChainRpcClientImpl, Endpoint, RemoteAccountProvider, | ||||||
| chain_updates_client::ChainUpdatesClient, ChainPubsubClient, | ||||||
| ChainRpcClient, ChainRpcClientImpl, Endpoint, RemoteAccountProvider, | ||||||
| }, | ||||||
| submux::SubMuxClient, | ||||||
| }; | ||||||
|
|
@@ -89,12 +89,7 @@ impl<T: ChainRpcClient, U: ChainPubsubClient, V: AccountsBank, C: Cloner> | |||||
| faucet_pubkey: Pubkey, | ||||||
| config: ChainlinkConfig, | ||||||
| ) -> ChainlinkResult< | ||||||
| Chainlink< | ||||||
| ChainRpcClientImpl, | ||||||
| SubMuxClient<ChainPubsubClientImpl>, | ||||||
| V, | ||||||
| C, | ||||||
| >, | ||||||
| Chainlink<ChainRpcClientImpl, SubMuxClient<ChainUpdatesClient>, V, C>, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chainStabilize the public return type with an alias to avoid downstream churn. Exposing Apply: @@
- ) -> ChainlinkResult<
- Chainlink<ChainRpcClientImpl, SubMuxClient<ChainUpdatesClient>, V, C>,
- > {
+ ) -> ChainlinkResult<
+ Chainlink<ChainRpcClientImpl, ChainUpdatesMuxClient, V, C>,
+ > {And define the alias once in this module (near other pub uses): @@
pub use blacklisted_accounts::*;
+/// Stable alias for the multiplexed updates client to keep backend details abstract.
+pub type ChainUpdatesMuxClient = SubMuxClient<ChainUpdatesClient>;Run to find other occurrences that could switch to the alias: 🏁 Script executed: #!/bin/bash
rg -nP --type=rust -C1 'SubMuxClient\s*<\s*ChainUpdatesClient\s*>'Length of output: 3562 Define and use a public type alias to stabilize the chain updates client interface. The pattern Suggested approach: Define the alias in pub use blacklisted_accounts::*;
+/// Stable alias for the multiplexed updates client to keep backend details abstract.
+pub type ChainUpdatesMuxClient = SubMuxClient<ChainUpdatesClient>;Update the public return type at line 92: - ) -> ChainlinkResult<
- Chainlink<ChainRpcClientImpl, SubMuxClient<ChainUpdatesClient>, V, C>,
- > {
+ ) -> ChainlinkResult<
+ Chainlink<ChainRpcClientImpl, ChainUpdatesMuxClient, V, C>,
+ > {Additional refactoring opportunities: Consider updating other public signatures in 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| > { | ||||||
| // Extract accounts provider and create fetch cloner while connecting | ||||||
| // the subscription channel | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.