Skip to content

chore: fix small typos #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SashaMalysehko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: fix small typos #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45fcf95
Update view-controller.ts
SashaMalysehko Dec 15, 2025
9967e4e
Update web-crypto.ts
SashaMalysehko Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@magic-sdk/provider/src/core/view-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export abstract class ViewController {
): RemoveEventListenerFunction {
const boundHandler = handler.bind(window);

// We cannot effectively cover this function because it never gets reference
// We cannot effectively cover this function because it never gets referenced
// by value. The functionality of this callback is tested within
// `initMessageListener`.
/* istanbul ignore next */
Expand Down
2 changes: 1 addition & 1 deletion packages/@magic-sdk/provider/src/util/web-crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async function generateWCKP() {
const { subtle } = window.crypto;
const kp = await subtle.generateKey(
EC_GEN_PARAMS,
false, // need to export the public key, while keep private key non-extractable
false, // need to export the public key, while keeping private key non-extractable
['sign'],
);

Expand Down