-
Notifications
You must be signed in to change notification settings - Fork 62
feat: rewrite the Editor the Rails way #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
did
wants to merge
128
commits into
master
Choose a base branch
from
feat-editor-the-rails-way
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… + TopBar component (WIP)
…ve a lot of components
…pbar and sidebar (easier customization)
chore: extra_fields -> spread_fields (option name)
chore: Rubocop ✅
chore: clean I18n keys (WIP) chore: clean the architecture of the Setting components
fix: fix the Link component (bad refactoring) fix: fix wrong i18n keys (WIP)
chore: Rubocop ✅ chore: clean the templates of the list of section blocks
fix: fix a couple of minor issues feat: display an empty message if no sections (WIP)
fix: the empty message is now correctly displayed fix: don't display a blank page title if the page hasn't been translated yet
fix: unable to set the very first icon
fix: fix minor UI issues
feat: optimistic locking enabled for sections, blocks and style
chore: don't update the page if the section is site scoped
chore: translate the error modals
feat: display an error modal for ApplicationError (unless it's local)
…ite scoped sections)
…esn't exist anymore
…n or the block doesn't exist
…ction setting (live preview)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdminUI (for developers)