fix(agw): Updated envopt for automatic rebase to pass during provision #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VinashakAnkitAman <[email protected]>
Signed-off-by: VinashakAnkitAman <[email protected]>
…ssfuly' of https://github.com/VinashakAnkitAman/S1APTester into ankit_updated_envopt_for_automatic_rebase_to_pass_successfuly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(agw): Updated envopt for automatic rebase to pass during provision
Summary
After S1APTester code compilation, we get the file envopt.h auto-modified, which creates problem while cloning the code automatically during provision. This leads to older S1APTester code working with the latest magma and sometimes needs S1APTester VM to destroy and recreate. This PR fixes the issue by committing the updated envopt.h file so that provision is sufficient enough to pull-in the latest changes every time.
Test plan
Verified with sanity