fix lint errors

.github/workflows/workflow.yml

@@ -1,5 +1,4 @@
-# .github/workflows/ansible-lint.yml
-name: ansible-lint
+name: workflow
 on:
   pull_request:
 jobs:

local.yml

@@ -48,11 +48,6 @@
     #     file: tasks/nodejs.yml
     # need to fix
 
-    # - name: Install brave
-    #   ansible.builtin.include_tasks:
-    #     file: tasks/brave.yml
-    # NOT TESTED
-
     - name: Install signal
       ansible.builtin.include_tasks:
         file: tasks/signal.yml

tasks/flathub.yml

@@ -6,7 +6,7 @@
     flatpakrepo_url: https://dl.flathub.org/repo/flathub.flatpakrepo
     method: user
   become: false
-  ignore_errors: true
+  failed_when: false
   when: not is_wsl
 
 - name: Install packages from flathub
@@ -16,5 +16,5 @@
       - com.notesnook.Notesnook
     method: user
   become: false
-  ignore_errors: true
+  failed_when: false
   when: not is_wsl

tasks/signal.yml

@@ -1,7 +1,14 @@
 ---
-- name: Download Signal GPG key and add to keyring
+- name: Download Signal GPG key
+  ansible.builtin.get_url:
+    url: https://updates.signal.org/desktop/apt/keys.asc
+    dest: /tmp/signal-desktop-key.asc
+    mode: "0644"
+  when: not is_wsl
+
+- name: Convert Signal GPG key to keyring format
   ansible.builtin.shell:
-    cmd: "wget -O- https://updates.signal.org/desktop/apt/keys.asc | gpg --dearmor > /tmp/signal-desktop-keyring.gpg"
+    cmd: "set -o pipefail && gpg --dearmor < /tmp/signal-desktop-key.asc > /tmp/signal-desktop-keyring.gpg"
   args:
     creates: /tmp/signal-desktop-keyring.gpg
   when: not is_wsl
@@ -13,7 +20,7 @@
     remote_src: false
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   when: not is_wsl
 
 - name: Add Signal repository to apt sources

tasks/spotify.yml

@@ -1,7 +1,14 @@
 ---
-- name: Add Spotify GPG key
-  ansible.builtin.shell: >
-    curl -sS https://download.spotify.com/debian/pubkey_C85668DF69375001.gpg | sudo gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg
+- name: Download Spotify GPG key
+  ansible.builtin.get_url:
+    url: https://download.spotify.com/debian/pubkey_C85668DF69375001.gpg
+    dest: /tmp/spotify_pubkey.gpg
+    mode: "0644"
+  when: not is_wsl
+
+- name: Add Spotify GPG key to trusted keyring
+  ansible.builtin.command:
+    cmd: gpg --dearmor --yes -o /etc/apt/trusted.gpg.d/spotify.gpg /tmp/spotify_pubkey.gpg
   args:
     creates: /etc/apt/trusted.gpg.d/spotify.gpg
   when: not is_wsl
@@ -11,6 +18,7 @@
     path: /etc/apt/sources.list.d/spotify.list
     line: "deb https://repository.spotify.com stable non-free"
     create: true
+    mode: "0644"
   when: not is_wsl
 
 - name: Update APT package index