[ACME] add support for ECDSA and phase out RSA#7250
Open
apio-sys wants to merge 1 commit into
Open
Conversation
Author
|
Could we get this at least in the nightly so that extensive testing can be done beyond what I did? I think this will be very beneficial to have included in the stable version as soon as possible. |
Author
|
Any chance of getting this merged? Or discuss further if needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
These changes aim to implement ECDSA certificates without disturbing an existing environment. There is no choice or setting to prefer RSA or ECDSA to avoid confusion. Anything new should be based on modern standards and RSA should be phased out progressively. So on a new instance, everything will be clean from the start. On an existing instance, everything will continue to work with RSA including when adding new domains unless the administrator decides to replace the RSA certificates with ECDSA by deleting them and let the script recreate everything needed (based on the other cert/SAN preferences in mailcow.conf of course). Inspired from the way Certbot handles this in recent releases.
See also the discussion in #2426 which is open since 2019.
Main motivation: the currently used certificates do not pass Internet.nl tests (for instance) hence are not future-ready.
Affected Containers
Did you run tests?
What did you test?
What were the final results?
Once the new certificates in place, one needs to update all depending TLSA records. These can be found as usual in the UI in E-Mail > Configuration > Domains > Domains > [domaine.fr] > DNS. TLSA records should typically have a short TTL, i.e. no more than 3600. It is worth checking beforehand if these records didn't have an abnormal long TTL which can otherwise result in email delivery failures during the change-over period and as long as the TTL itself.
If this PR is acceptable and accepted, I shall endeavor to add the above change-over instructions in the mailcow-dockerized-docs repo.