[Web] redirect deep links to the matching login page#7349
Open
smpaz7467 wants to merge 1 commit into
Open
Conversation
An unauthenticated request to a deep link such as /admin/dashboard was redirected to /, the user login, instead of the admin login. protect_route always sent unauthenticated visitors to /. Pick the login page from the request path: /admin/* redirects to /admin, /domainadmin/* to /domainadmin, everything else to / as before. Fixes mailcow#7284 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An unauthenticated request to a deep link like
/admin/dashboardredirected to/(the user login) instead of the admin login.
protect_route()sent everyunauthenticated visitor to
/regardless of which area the link belonged to.Fix
Choose the login page from the request path in the unauthenticated branch of
protect_route():/admin/*→/admin/domainadmin/*→/domainadmin/(unchanged)Verification (live stack, unauthenticated
curl)/admin/dashboard//admin/admin/mailbox//admin/domainadmin/mailbox//domainadmin/user//(unchanged)php -lclean.Scope
This lands deep links on the correct login page, as the issue asks. It does not
implement the reporter's optional "redirect back to the originally requested URL
after login" idea — that's a larger change (persisting and validating a return URL)
and better handled separately.
Fixes #7284