Reset state properly #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per RFC 5321, sections 4.1.1.5 and 4.1.4, issuing an RSET command should not result in the HELO/EHLO domain being removed from the session. From section 4.1.1.5: > It is effectively equivalent to a NOOP (i.e., it has no > effect) if issued immediately after EHLO, before EHLO is > issued in the session, after an end of data indicator has > been sent and acknowledged, or immediately before a QUIT. And: > Since EHLO implies some additional processing and response by the > server, RSET will normally be more efficient than reissuing that > command, even though the formal semantics are the same.
Based on RFC 5321, section 4.1.4, any stored values should be reset if a HELO/EHLO command is sent subsequent to the original: > An EHLO command MAY be issued by a client later in the session. If > it is issued after the session begins and the EHLO command is > acceptable to the SMTP server, the SMTP server MUST clear all buffers > and reset the state exactly as if a RSET command had been issued. In > other words, the sequence of RSET followed immediately by EHLO is > redundant, but not harmful other than in the performance cost of > executing unnecessary commands.
Open
Author
|
Fixes #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HELO/EHLOdomain was being lost during anRSET. This fixes that.