Skip to content

Conversation

@VladimirTaytor
Copy link
Contributor

@VladimirTaytor VladimirTaytor commented Oct 24, 2025

Motivation

We want to make new release

Changes

  • Bump version to v2.3.0

Summary by CodeRabbit

  • New Features
    • Introduced batch sending functionality across multiple API endpoints, enabling efficient processing of bulk requests in a single operation.

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Walkthrough

A version bump from 2.2.0 to 2.3.0 across pyproject.toml and CHANGELOG.md. The changelog documents the addition of batch_send methods to SendingApi, GeneralApi, ContactExportsApi, and ContactEventsApi with corresponding models, tests, and examples.

Changes

Cohort / File(s) Summary
Version Bump
pyproject.toml
Updated project version from 2.2.0 to 2.3.0
Release Notes
CHANGELOG.md
Added new 2.3.0 section with four fix entries documenting batch_send method additions to SendingApi, GeneralApi, ContactExportsApi, and ContactEventsApi including models, tests, and examples

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version hops from two-point-two,
New batch methods in every API brew,
Changelog sings of fixes so bright,
Sending and contact events take flight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the Motivation and Changes sections from the template but is missing the "How to test" and "Images and GIFs" sections. Additionally, the Motivation section is very brief and generic, stating only "We want to make new release" without providing meaningful context. While the Changes section is present and describes the version bump, the overall description is incomplete relative to the provided template structure and lacks substantive detail in the motivation. The description should be expanded to include all template sections. The Motivation section should provide more specific context about why this release is being made (e.g., what features or fixes are included in v2.3.0). The "How to test" section should include relevant testing steps or checkboxes, and if applicable, the "Images and GIFs" section can be omitted for version bump PRs with a note explaining its irrelevance.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Bump version to v2.3.0" accurately and specifically describes the primary change in the changeset. The title is concise, clear, and directly summarizes what the PR does—bumping the version from 2.2.0 to 2.3.0 across both pyproject.toml and CHANGELOG.md. It avoids vague terminology and provides sufficient detail for teammates to understand the main change when scanning commit history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-v2.3.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

1-5: Wrap bare URLs in angle brackets to comply with markdown style guidelines.

The new 2.3.0 changelog entries contain bare URLs that violate the markdown linting rule MD034 (no-bare-urls). While the existing 2.2.0 section follows the same pattern, it's preferable to wrap URLs in angle brackets for consistency with markdown best practices.

Apply this diff to wrap the URLs:

-## [2.3.0] - 2025-10-24
-* Fix issue #24: Add batch_send method to SendingApi, add models by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/47
-* Fix issue #42: Add GeneralApi, related models, examples, tests. by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/48
-* Fix issue #41: Add ContactExportsApi, related models, tests and examples by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/49
-* Fix issue #45: Add ContactEventsApi, related models, tests and examples by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/51
+## [2.3.0] - 2025-10-24
+* Fix issue #24: Add batch_send method to SendingApi, add models by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/47>
+* Fix issue #42: Add GeneralApi, related models, examples, tests. by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/48>
+* Fix issue #41: Add ContactExportsApi, related models, tests and examples by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/49>
+* Fix issue #45: Add ContactEventsApi, related models, tests and examples by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/51>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd7b89 and 22b98fb.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md

2-2: Bare URL used

(MD034, no-bare-urls)


3-3: Bare URL used

(MD034, no-bare-urls)


4-4: Bare URL used

(MD034, no-bare-urls)


5-5: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Test python3.9 on macos-latest
  • GitHub Check: Test python3.11 on windows-latest
  • GitHub Check: Test python3.10 on windows-latest
  • GitHub Check: Test python3.13 on windows-latest
  • GitHub Check: Test python3.12 on windows-latest
  • GitHub Check: Test python3.9 on windows-latest
  • GitHub Check: Test python3.10 on windows-latest
  • GitHub Check: Test python3.13 on windows-latest
  • GitHub Check: Test python3.11 on windows-latest
  • GitHub Check: Test python3.12 on windows-latest
🔇 Additional comments (2)
pyproject.toml (1)

3-3: Version bump to 2.3.0 is correctly applied.

The version field update aligns with the CHANGELOG.md entry and follows the pyproject.toml format specification.

CHANGELOG.md (1)

1-5: Changelog entries accurately document the v2.3.0 release.

The four entries correctly capture the batch_send method additions across SendingApi, GeneralApi, ContactExportsApi, and ContactEventsApi, with proper issue/PR references for traceability.

Copy link
Contributor

@andrii-porokhnavets andrii-porokhnavets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we wait for the updated README?

@VladimirTaytor
Copy link
Contributor Author

@andrii-porokhnavets Release was already done, if we want one more it will be another one

@yanchuk
Copy link
Contributor

yanchuk commented Oct 28, 2025

@VladimirTaytor Readme PR is merged, so we can maybe merge that as well and bump version

@yanchuk yanchuk self-requested a review October 28, 2025 12:20
@VladimirTaytor VladimirTaytor merged commit 8322164 into main Oct 28, 2025
31 checks passed
@VladimirTaytor VladimirTaytor deleted the release-v2.3.0 branch October 28, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants