Better export init signature

Allow to pass a sheet to a non-sqla exporter version 0.3.2
majerteam · Feb 24, 2016 · eb6bdaa · eb6bdaa
1 parent d95d378
commit eb6bdaa
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 
 setup(
     name='sqla_inspect',
-    version='0.3.1',
+    version='0.3.2',
     packages=['sqla_inspect'],
     include_package_data=True,
     license='GPLv3',

diff --git a/sqla_inspect/__init__.py b/sqla_inspect/__init__.py
@@ -1 +1 @@
-__version__ = '0.3.1'
+__version__ = '0.3.2'
diff --git a/sqla_inspect/excel.py b/sqla_inspect/excel.py
@@ -218,8 +218,8 @@ class SqlaXlsExporter(XlsWriter, SqlaExporter):
     def __init__(self, model, guess_types=True, worksheet=None):
         self.guess_types = guess_types
         self.is_root = worksheet is None
-        XlsWriter.__init__(self, guess_types, worksheet)
-        SqlaExporter.__init__(self, model)
+        XlsWriter.__init__(self, guess_types=guess_types, worksheet=worksheet)
+        SqlaExporter.__init__(self, model=model)
 
     def _get_related_exporter(self, related_obj, column):
         """
@@ -284,6 +284,10 @@ class XlsExporter(XlsWriter, BaseExporter):
     """
     headers = ()
 
-    def __init__(self, guess_types=True):
-        XlsWriter.__init__(self, guess_types=True)
-        BaseExporter.__init__(self)
+    def __init__(self, guess_types=True, **kw):
+        XlsWriter.__init__(
+            self,
+            guess_types=guess_types,
+            **kw
+        )
+        BaseExporter.__init__(self, **kw)
diff --git a/sqla_inspect/ods.py b/sqla_inspect/ods.py
@@ -208,5 +208,5 @@ class OdsExporter(OdsWriter, BaseExporter):
     headers = ()
 
     def __init__(self, title=None, **kw):
-        OdsWriter.__init__(self, title)
+        OdsWriter.__init__(self, title, **kw)
         BaseExporter.__init__(self, **kw)