Skip to content

Rebase copilot/fix-xlsx-export-issue onto master #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Rebase copilot/fix-xlsx-export-issue onto master #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ebe8b0
Initial plan
Copilot Oct 19, 2025
297cfe6
Fix XLSX export issues for Excel 2013 compatibility
Copilot Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions RdlEngine/Render/ExcelValet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,14 @@ void WriteStyles(ZipOutputStream zip)
}
sb.AppendLine("</numFmts>");
// output the font list
sb.AppendFormat("<fonts count=\"{0}\">", _FontCache.Count);
// Excel requires at least one font to be defined
int fontCount = _FontCache.Count > 0 ? _FontCache.Count : 1;
sb.AppendFormat("<fonts count=\"{0}\">", fontCount);
if (_FontCache.Count == 0)
{
// Add a default font if none exists
sb.AppendLine("<font><sz val=\"11\"/><color rgb=\"FF000000\"/><name val=\"Calibri\"/></font>");
}
foreach (string f in _FontCache)
{
sb.AppendLine(f);
Expand Down Expand Up @@ -639,12 +646,22 @@ void WriteWorkbookRels(ZipOutputStream zip)
"<Relationships xmlns=\"http://schemas.openxmlformats.org/package/2006/relationships\">");

int id = 1;
foreach (SheetInfo sinfo in _Sheets)
if (_Sheets.Count == 0)
{
// Add relationship for the empty sheet that will be created
sb.AppendFormat("<Relationship Id=\"rId{0}\" Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet\" " +
"Target=\"worksheets/{1}.xml\"/>", id, sinfo.Name);
"Target=\"worksheets/sheet1.xml\"/>", id);
id++;
}
else
{
foreach (SheetInfo sinfo in _Sheets)
{
sb.AppendFormat("<Relationship Id=\"rId{0}\" Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet\" " +
"Target=\"worksheets/{1}.xml\"/>", id, sinfo.Name);
id++;
}
}

sb.AppendFormat("<Relationship Id=\"rId{0}\" " +
"Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/sharedStrings\" " +
Expand Down
Loading