-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Wallet migration #977
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Report too large to display inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some very small changes for some minor issues I found while testing, but all the transactions worked as expected.
What a beast of a PR. Excellent work! 🔥
One more note: Not urgent, but we can update the references to ethers in the README to wagmi/viem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! In addition to what Adam said, we also want to update the README steps to get it running locally & the sample.env. Also found some SKY number formatting issues but they can probably be addressed in a different PR. Good to get this merged into the main feature branch soon!
This reverts commit 53275d9.
What does this PR do?
Misc: