Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy app: Disable write contract interactions #994

Open
wants to merge 1 commit into
base: feat/wallet-migration
Choose a base branch
from

Conversation

hernandoagf
Copy link
Collaborator

What does this PR do?

  • Disable all write contract interactions in the web app except for chief free (withdraw MKR), old chief free, delegate free (undelegating) and IOU tokens approval
  • Hardcode the disable prop of some buttons to true to avoid triggering modals with dead ends

List of interactions disabled:

  • Poll creation
  • Poll vote (legacy and gasless)
  • Token approvals for DAI and MKR (still allowed for IOU and IOU_OLD as those are required for withdrawing)
  • Chief lock - MKR deposit (EOA and proxy contract)
  • Executive vote (EOA, proxy contract and delegate)
  • Delegate contract creation
  • Delegate lock
  • ESM burn and ESM shutdown

Steps for testing:

Attempt to perform any of the write contract interactions specified in the disabled list above, you shouldn't be able to do so

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 10:33pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant