-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove offboarded collaterals #48
Conversation
TLDR: good to deploy
|
Good to deploy!
./scripts/test-forge.sh match="" match-test="" match-contract=""
[⠊] Compiling...
[⠒] Compiling 5 files with Solc 0.6.12
[⠑] Solc 0.6.12 finished in 528.23ms
Compiler run successful!
Ran 1 test for src/MegaPoker.t.sol:MegaPokerTest
[PASS] test_poke() (gas: 1473503)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 27.24s (25.42s CPU time)
Ran 6 tests for src/OmegaPoker.t.sol:OmegaPokerTest
[PASS] testPoke() (gas: 2870284)
[PASS] testPokeCost() (gas: 2671282)
[PASS] testRefresh() (gas: 2178466)
[PASS] testRefreshCost() (gas: 1118811)
[PASS] testRefreshZeroPip() (gas: 1796724)
[PASS] test_poke() (gas: 2671527)
Suite result: ok. 6 passed; 0 failed; 0 skipped; finished in 76.24s (156.52s CPU time)
Ran 2 test suites in 80.04s (103.49s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests) |
This comment was marked as outdated.
This comment was marked as outdated.
Contract deployed to 0x021CfECaF7027d736f796f8FC62c6513e04ca0D4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to handover the address to TechOps
- ✅ Verified code exactly matches updated source code
- ℹ️ No constructor arguments present to check
- ✅ Optimisation parameters (
Yes with 200 runs
) match previously deployed contract - ✅ EvmVersion
istanbul
same as in the previous deployment - ✅ Readme is updated with the new address
- ✅ No other changes were made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to handover
- ✅ Source code is verified on etherscan
- ✅ Compilation optimizations match previous contract
- ✅ Source code matches PRs code
- ✅ README was updated with new address
- ✅ No other changes were made after good to deploy
This PR removes offboarded collaterals
RETH-A
CRVV1ETHSTETH-A
Both collaterals have
Art
andline
set to 0 (checked here)