Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove offboarded collaterals #48

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

SidestreamStrongStrawberry
Copy link
Contributor

This PR removes offboarded collaterals

  • RETH-A
  • CRVV1ETHSTETH-A

Both collaterals have Art and line set to 0 (checked here)

@DaiFoundation-DevOps
Copy link

DaiFoundation-DevOps commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

@SidestreamColdMelon
Copy link

SidestreamColdMelon commented Mar 19, 2025

TLDR: good to deploy

  • ✅ Both removed collaterals are fully offboarded
    • RETH-A: MCD_VAT.ilks(0x524554482d41) returns 0 line, 0 Art
    • CRVV1ETHSTETH-A: MCD_VAT.ilks(0x435256563145544853544554482d41) returns 0 line, 0 Art
  • ✅ Scope of the PR is correct
    • PIP_RETH.poke() is removed
    • PIP_CRVV1ETHSTETH.poke() is removed
    • MCD_SPOT.poke("RETH-A") is removed
    • MCD_SPOT.poke("CRVV1ETHSTETH-A") is removed
    • Relevant unused declarations are removed
    • Relevant tests are removed
    • Nothing else is modified
  • ✅ No new lines are added
  • ✅ Local tests pass
./scripts/test-forge.sh match="" match-test="" match-contract=""
[⠊] Compiling...
[⠒] Compiling 5 files with Solc 0.6.12
[⠑] Solc 0.6.12 finished in 557.02ms
Compiler run successful!

Ran 1 test for src/MegaPoker.t.sol:MegaPokerTest
[PASS] test_poke() (gas: 1425883)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 10.88s (9.76s CPU time)

Ran 6 tests for src/OmegaPoker.t.sol:OmegaPokerTest
[PASS] testPoke() (gas: 2850666)
[PASS] testPokeCost() (gas: 2651664)
[PASS] testRefresh() (gas: 2178466)
[PASS] testRefreshCost() (gas: 1118811)
[PASS] testRefreshZeroPip() (gas: 1796724)
[PASS] test_poke() (gas: 2651909)
Suite result: ok. 6 passed; 0 failed; 0 skipped; finished in 24.10s (44.58s CPU time)

Ran 2 test suites in 24.54s (34.98s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)
  • ⚠️ The readme with the newly deployed address will be edited later

@SidestreamIcedMango
Copy link

Good to deploy!

  • ✅ checked that collaterals RETH-A and CRVV1ETHSTETH-A were removed
  • ✅ checked that nothing else was added, modified or removed
  • ✅ tests pass locally
./scripts/test-forge.sh match="" match-test="" match-contract=""
[⠊] Compiling...
[⠒] Compiling 5 files with Solc 0.6.12
[⠑] Solc 0.6.12 finished in 528.23ms
Compiler run successful!

Ran 1 test for src/MegaPoker.t.sol:MegaPokerTest
[PASS] test_poke() (gas: 1473503)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 27.24s (25.42s CPU time)

Ran 6 tests for src/OmegaPoker.t.sol:OmegaPokerTest
[PASS] testPoke() (gas: 2870284)
[PASS] testPokeCost() (gas: 2671282)
[PASS] testRefresh() (gas: 2178466)
[PASS] testRefreshCost() (gas: 1118811)
[PASS] testRefreshZeroPip() (gas: 1796724)
[PASS] test_poke() (gas: 2671527)
Suite result: ok. 6 passed; 0 failed; 0 skipped; finished in 76.24s (156.52s CPU time)

Ran 2 test suites in 80.04s (103.49s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)

@SidestreamStrongStrawberry

This comment was marked as outdated.

@SidestreamStrongStrawberry
Copy link
Contributor Author

Contract deployed to 0x021CfECaF7027d736f796f8FC62c6513e04ca0D4

Copy link

@SidestreamColdMelon SidestreamColdMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to handover the address to TechOps

  • ✅ Verified code exactly matches updated source code
  • ℹ️ No constructor arguments present to check
  • ✅ Optimisation parameters (Yes with 200 runs) match previously deployed contract
  • ✅ EvmVersion istanbul same as in the previous deployment
  • ✅ Readme is updated with the new address
  • ✅ No other changes were made

Copy link

@SidestreamIcedMango SidestreamIcedMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to handover

  • ✅ Source code is verified on etherscan
  • ✅ Compilation optimizations match previous contract
  • ✅ Source code matches PRs code
  • ✅ README was updated with new address
  • ✅ No other changes were made after good to deploy

@SidestreamColdMelon SidestreamColdMelon merged commit 8c5cb4c into master Mar 20, 2025
2 checks passed
@SidestreamColdMelon SidestreamColdMelon deleted the remove-offboarded-collaterals branch March 20, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants