Mainnet spell 2025-03-06

[0xp3th1um]

Description

Contribution Checklist

• PR title starts with (PE-<TICKET_NUMBER>)
• Code approved
• Tests approved
• CI Tests pass

Checklist

• Every contract variable/method declared as public/external private/internal
• Consider if this PR needs the officeHours modifier override
• Verify expiration (30 days unless otherwise specified)
• Verify hash in the description matches here
• Validate all addresses used are in changelog or known
• Notify any external teams affected by the spell so they have the opportunity to review
• Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• Verify mainnet contract on etherscan
• Change test to use mainnet spell address and deploy timestamp
• Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• squash and merge this PR

[SidestreamBurningBanana]

Another point about cleanup that I believe is worth raising:

• In Mainnet spell 2025-02-21 @SidestreamStrongStrawberry introduced a change in scripts/test-dssspell-forge.sh to the gas and memory limit of Foundry, which needs to be cleaned up

[0xp3th1um]

727152a

fixed in 727152a

[0xdecr1pto]

Good to deploy

Mainnet Executive Spell Review Checklist

Development Stage

• Install stable Foundry version

  • Find the first Foundry release that is older than 7 days from now
    • Insert the release URL here:
      https://github.com/foundry-rs/foundry/releases/tag/nightly-9bcfbaa6e6066fb9f87ce07163f5479d4b124563
  • Install the specified version via foundryup --version git_tag_name

        foundryup: installing foundry (version nightly, tag nightly-9bcfbaa6e6066fb9f87ce07163f5479d4b124563) 
        foundryup: downloading latest forge and cast 
        ######################################################################################################################################################################################################################################################### 100.0%
        foundryup: downloading manpages 
        ######################################################################################################################################################################################################################################################### 100.0%
        foundryup: installed - forge Version: 1.0.0-nightly
        Commit SHA: 9bcfbaa6e6066fb9f87ce07163f5479d4b124563 
        Build Timestamp: 2025-02-26T00:21:46.226845000Z (1740529306) 
        Build Profile: maxperf 
        foundryup: installed - cast Version: 1.0.0-nightly 
        Commit SHA: 9bcfbaa6e6066fb9f87ce07163f5479d4b124563 
        Build Timestamp: 2025-02-26T00:21:46.226845000Z (1740529306) 
        Build Profile: maxperf foundryup: done
    

• Preparation

  • Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet
    https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit?gid=1558518178#gid=1558518178
  • Using Exec Sheet URL from the above, read spell instructions from the Exec Sheet and list them below

    • Init Nova Allocator Instance

      • Rename chainlog key PIP_ALLOCATOR_SPARK_A into PIP_ALLOCATOR

      • Init new Allocator instance by calling AllocatorInit.initIlk with:

        • sharedInstance.oracle: PIP_ALLOCATOR from chainlog
        • sharedInstance.roles: ALLOCATOR_ROLES from chainlog
        • sharedInstance.registry: ALLOCATOR_REGISTRY from chainlog
        • ilkInstance.owner: MCD_PAUSE_PROXY from chainlog
        • ilkInstance.vault: 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77
        • ilkInstance.buffer: 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c
        • cfg.ilk: ALLOCATOR-NOVA-A
        • cfg.duty: 0%
        • cfg.gap: 1 million
        • cfg.maxLine: 60 million
        • cfg.ttl: 20 hours
        • cfg.allocatorProxy: MCD_PAUSE_PROXY from chainlog
        • cfg.ilkRegistry: ILK_REGISTRY from chainlog

      • Remove newly created PIP_ALLOCATOR_NOVA_A from chainlog

      • "Approve Operator to transfer USDS out of the AllocatorBuffer with:
        "

        • address asset: USDS from chainlog
        • address spender: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint256 amount: type(uint256).max

      • Allow Operator to call “draw” and “wipe” functions using ALLOCATOR_ROLES, with:

        • bytes32 ilk: ALLOCATOR-NOVA-A
        • address who: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint8 role: 0
        • bool enabled: true

      • Add ALLOCATOR-NOVA-A ilk to the LINE_MOM

    • Smart Burn Engine Parameter Update

      • Increase hop for 1284 seconds, from 876 seconds to 2160 seconds

    • Rates Changes

      • Increase ALLOCATOR-SPARK-A Stability Fee by 0.52 percentage points from 3.22% to 3.74%
      • Increase DSR by 0.75 percentage points from 4.75% to 5.50%

    • Launch Project Funding

      • Transfer 5,000,000 USDS to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F
      • Transfer 9,600,000 SKY to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F

    • Top-up of the Integration Boost

      • Integration Boost - 3,000,000 USDS - 0xD6891d1DFFDA6B0B1aF3524018a1eE2E608785F7

    • Add DssBlow2 to the Chainlog

      • Add DssBlow2 to the Chainlog as MCD_BLOW2 at 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79

    • Spark Proxy Spell

      • Trigger Spark Proxy Spell at 0xBeA5FA2bFC4F6a0b6060Eb8EC23F25db8259cEE0

• Base checks

  • Current solc version 0.8.16
  • Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • Office hours value matches the Exec Sheet
  • 30 days spell expiry set in the constructor (block.timestamp + 30 days)

• Spell description

  • Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • TARGET_DATE in the description matches the target date
  • Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"

• Comments inside the spell

  • Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • Every Instruction text have newline above it
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
    • // Poll: if URL starts with https://vote.makerdao.com/polling/
    • // Forum: if URL starts with https://forum.makerdao.com/t/

• Dependency checks

  • Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out 'a8a7b151c39282d4ddab8cb4ead2d80342df588f'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out '978ac6fadb62f5f0b723c996f64be52eddba6801'

  • git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
  • dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test

• IF interfaces are present in the spell

  • Static Interfaces
    • No unused static interfaces
    • Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
    • Interface matches deployed contract using cast interface <contract_address> command
    • Interface naming style should match with Like suffix (e.g. VatLike)
      • EXCEPTION: known interface naming exceptions
    • Each static interface declare only functions actually used in the spell code

• IF variable declarations are present in the spell

  • IF precision units are present
    • Precision units used in the spell match their defined values:
      • WAD = 10 ** 18
      • RAY = 10 ** 27
      • RAD = 10 ** 45
    • Precision units match with Numerical Ranges
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF rates are present
    • Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Rates match IPFS document
    • Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
    • Rate variable visibility declared as internal
    • Rate variable state mutability declared as constant

• IF new contract is present in the spell (not yet on chainlog or new to chainlog)

  • AllocatorBuffer deployed at 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c
    • Source code is verified on etherscan
    • Compilation optimizations match deployment settings defined in the source code repo
      • matches here
    • GNU AGPLv3 license
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure that there are no other Rely events except for PAUSE_PROXY (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
      • Audited contract code
    • Deployer address is included into addresses_deployers.sol
  • AllocatorVault deployed at 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77
    • Source code is verified on etherscan
    • Compilation optimizations match deployment settings defined in the source code repo
      • matches here
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      • address roles_ being ALLOCATOR_ROLES from chainlog
      • address buffer_ being deployed AllocatorBuffer address
      • bytes32 ilk_ being ALLOCATOR-NOVA-A
      • address usdsJoin_ being USDS_JOIN from chainlog
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure that there are no other Rely events except for PAUSE_PROXY (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
      • Audited contract code
    • Deployer address is included into addresses_deployers.sol
  • DssBlow2 deployed at 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79
    • Source code is verified on etherscan
    • Compilation optimizations match deployment settings defined in the source code repo
      • matches here
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      • address daiJoin_ being MCD_JOIN_DAI from chainlog
      • address usdsJoin_ being USDS_JOIN from chainlog
      • address vow_ being MCD_VOW from chainlog
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
      • Audited contract code
    • Deployer address is included into addresses_deployers.sol

• IF core system parameter changes are present in the instructions

  • IF stability fee (jug.ilk.duty) is updated
    • (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
    • Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
    • (DssExecLib.setDSR(rate, doDrip)) is used
    • Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
    • Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Double check that rate match IPFS document

• IF additional dependencies (i.e. ./src/dependencies/ directory) are present:

  • dss-allocator
    • IF the dependencies contracts/libraries have been audited
      • Each contract/library exactly matches (i.e. diff check) the source code of the latest audited version
      • Matches with audited commit 226584d3b179d98025497815adb4ea585ea0102d

• IF onboarding is present

  • Insert and follow the relevant checklists below:

    Collateral Onboarding Checklist

    collateral onboarding checklist doesn't fully match with collateral class 5
    • Deployed Contracts

      • PIP (Oracle)

        • deployed via deployer (OSM)
          • contract is verified on etherscan
            • ensure solc version matches source
            • ensure optimization matches source configs
            • ensure license AGPLv3 is specified
            • ensure source matches github code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol)

      • Risk Parameters

        • vat.ilk.line (setIlkDebtCeiling)
        • jug.ilk.duty (setIlkStabilityFee)
        • spotter.ilk.mat (liquidationRatio)

      • Autoline (setIlkAutoLineParameters)

        • ilk
        • line
        • gap
        • ttl

      • Onboarding Actions

        • ensure DssExecLib.addNewCollateral is used
          done by dss-allocator dependency

        • ensure CollateralOpts is used
          CollateralOpts not used because DssExecLib.addNewCollateral was not used and it is expected

          • ilk follows the ilk format TOKEN-A

          • pip matches token pip address

          • ilkDebtCeiling (vat.ilk.line) in DAI (e.g. 1 * MILLION)

            • IF autoline is enabled, vat.ilk.line should be set to DC-IAM gap value

          • ilkStabilityFee (jug.ilk.duty) set via script or IPFS rates table (e.g. 1000000000031693947650284507)

        • set Ilk Autoline Parameters (IF Autoline is enabled)

          • ilk follows the ilk format TOKEN-A
          • linein DAI (e.g. 10 * MILLION)
          • gap in DAI (e.g. 1 * MILLION)
          • ttl in seconds (e.g. 8 hours)

      • New Chainlog Entries

        • PIP_TOKEN

      • Chainlog Bump

        • Patch x.x.1

      • Test Coverage (Follow Previous Test Patterns)

        • testCollateralIntegrations
          Tested by testAllocatorIntegration
        • testNewChainlogValues
          The above test is not used anymore and chainlog values are tested by testChainlogIntegrity and testChainlogValues
        • testNewIlkRegistryValues
          Tested by testAllocatorIntegration
        • ensure new chainlog entries are included in addresses_<mainnet, goerli>.sol
        • ensure deployer addresses are included into addresses_deployers.sol (to keep up to date)
        • config.sol

• IF payments are present in the spell

  • IF MKR transfers are present ℹ️ Note: not MKR, but SKY transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • The transfers are tested via testMKRPayments test
      Since last year, all payments are tested via testPayments
    • Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Sheet
  • IF DAI surplus buffer transfers are present ℹ️ Note: not DAI, but USDS transfers are present
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • The transfers are tested via testDAIPayments test
      Since last year, all payments are tested via testPayments
    • Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Sheet

• IF SubDAO-related content is present

  • IF SubDAO provides SubProxy spell address
    • SubDAO spell address matches Exec Sheet
    • Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
    • Execution is NOT delegate call
    • Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts
      ⚠️ This will be properly tested in the next stage, during tenderly simulation

• IF spell interacts with ChainLog

  • ChainLog version is incremented based on update type
    • Major -> New Vat (++.0.0)
    • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
    • Patch -> Collateral addition or addition/modification (0.0.++)
  • New addresses are added to the addresses_mainnet.sol
  • Changes are tested via testChainlogIntegrity and testChainlogValues

• Ensure every spell variable is declared as public/internal

• Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses

  • Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)

• Tests

  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    ad72002
  • Ensure every test function is declared as public
    • IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • Ensure each spell action has sufficient test coverage
    • Init Allocator System for NOVA Subdao
      • Rename chainlog key PIP_ALLOCATOR_SPARK_A into PIP_ALLOCATOR
        • test via testChainlogValues
      • Remove newly created PIP_ALLOCATOR_NOVA_A from chainlog
        • tested via testRemoveChainlogValues
      • Init Allocator ILK for NOVA Subdao by calling AllocatorInit.initIlk using the following parameters:
        • tested via testAllocatorIntegration and testGeneral
      • "Approve Operator to transfer USDS out of the AllocatorBuffer with:"
        • tested via testAllocatorIntegration
      • Allow Operator to call “draw” and “wipe” functions using ALLOCATOR_ROLES, with:
        • tested via testAllocatorIntegration
      • Add ALLOCATOR-NOVA-A ilk to the LINE_MOM
        • tested via testNewLineMomIlks
    • Smart Burn Engine Parameter Update
      • tested via testGeneral
    • Rates Changes
      • Increase ALLOCATOR-SPARK-A Stability Fee by 0.52 percentage points from 3.22% to 3.74%
        • tested via testGeneral
      • Increase DSR by 0.75 percentage points from 4.75% to 5.50%
        • tested via testGeneral
    • Launch Project Funding
      • Tested via testPayments
    • Top-up of the Integration Boost
      • Tested via testPayments
    • Add DssBlow2 to the Chainlog
      • tested via testChainlogIntegrity, testChainlogValues, testAddChainlogKeys
    • Spark Proxy Spell
      • tested via testSparkSpellIsExecuted
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • IF a new module is initialized via the spell, the tests must include
    • Sanity checks of the constructor arguments
    • Sanity checks of all values added/updated by the spell function
    • End-to-end "happy path" interaction with the module
  • Check all tests are passing locally using make test
    • Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

[⠊] Compiling...
[⠢] Compiling 4 files with Solc 0.8.16
[⠰] Solc 0.8.16 finished in 2.25s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2421967)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 25.19s (21.72s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  snapshot(): replaced by `snapshotState`
  revertTo(uint256): replaced by `revertToState`
Ran 43 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAddChainlogKeys() (gas: 2348357)
[PASS] testAllocatorIntegration() (gas: 2630544)
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 2254775)
[PASS] testCastOnTime() (gas: 2250525)
[PASS] testChainlogIntegrity() (gas: 7869903)
[PASS] testChainlogValues() (gas: 12321290)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 15832)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 4696478)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34992989)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 3264270)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNewLineMomIlks() (gas: 2260799)
[PASS] testNextCastTime() (gas: 458207)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 497350)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 3585464)
[PASS] testPayments() (gas: 2376560)
[PASS] testRemoveChainlogValues() (gas: 2259456)
[PASS] testRevertIfNotScheduled() (gas: 17596)
[PASS] testSparkSpellIsExecuted() (gas: 2256484)
[PASS] testSplitter() (gas: 2754645)
[PASS] testSystemTokens() (gas: 3470880)
[PASS] testUseEta() (gas: 354708)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 21 passed; 0 failed; 22 skipped; finished in 176.68s (549.88s CPU time)

Ran 2 test suites in 177.03s (201.86s CPU time): 23 tests passed, 0 failed, 22 skipped (45 total tests)

Pre-Deployment Stage

• Wait till the Exec Doc is merged
• Exec Doc checks
  • Exec Doc for the specified date is found in the makerdao/community GitHub repo
  • Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • Extract permanent URL to the raw markdown file and paste it below
    Insert your Raw Exec Doc URL here
    https://github.com/makerdao/community/blob/878d6d6f39c0fec5ff53e9f05a99e8e60f0fb7d4/governance/votes/Executive%20vote%20-%20March%206%2C%202025.md
  • Ensure the URL uses commit hash that introduced last change to the Exec Doc, NOT merge commit
    • OTHERWISE, ensure it is pointing to the latest commit on master:

      git switch master && git pull origin master
      

    • Get the latest commit hash for the exec doc:

      git log --pretty=oneline -1 -- "<LOCAL_PATH_TO_EXEC_DOC>"
      

  • Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
    0x41dccf735863cd3893322b6f61651b8e518761705326dcae95d5fe882ec47655
  • Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
    0x41dccf735863cd3893322b6f61651b8e518761705326dcae95d5fe882ec47655
  • Make sure that hash above doesn't match keccak hash of the empty string (0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470)
  • Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below

    • Init Nova Allocator Instance

      • Rename chainlog key PIP_ALLOCATOR_SPARK_A into PIP_ALLOCATOR

      • Init new Allocator instance by calling AllocatorInit.initIlk with:

        • sharedInstance.oracle: PIP_ALLOCATOR from chainlog
        • sharedInstance.roles: ALLOCATOR_ROLES from chainlog
        • sharedInstance.registry: ALLOCATOR_REGISTRY from chainlog
        • ilkInstance.owner: MCD_PAUSE_PROXY from chainlog
        • ilkInstance.vault: 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77
        • ilkInstance.buffer: 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c
        • cfg.ilk: ALLOCATOR-NOVA-A
        • cfg.duty: 0%
        • cfg.gap: 1 million
        • cfg.maxLine: 60 million
        • cfg.ttl: 20 hours
        • cfg.allocatorProxy: MCD_PAUSE_PROXY from chainlog
        • cfg.ilkRegistry: ILK_REGISTRY from chainlog

      • Remove newly created PIP_ALLOCATOR_NOVA_A from chainlog

      • "Approve Operator to transfer USDS out of the AllocatorBuffer with:
        "

        • address asset: USDS from chainlog
        • address spender: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint256 amount: type(uint256).max

      • Allow Operator to call “draw” and “wipe” functions using ALLOCATOR_ROLES, with:

        • bytes32 ilk: ALLOCATOR-NOVA-A
        • address who: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint8 role: 0
        • bool enabled: true

      • Add ALLOCATOR-NOVA-A ilk to the LINE_MOM

    • Smart Burn Engine Parameter Update

      • Increase hop for 1284 seconds, from 876 seconds to 2160 seconds

    • Rates Changes

      • Increase ALLOCATOR-SPARK-A Stability Fee by 0.52 percentage points from 3.22% to 3.74%
      • Increase DSR by 0.75 percentage points from 4.75% to 5.50%

    • Launch Project Funding

      • Transfer 5,000,000 USDS to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F
      • Transfer 9,600,000 SKY to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F

    • Top-up of the Integration Boost

      • Integration Boost - 3,000,000 USDS - 0xD6891d1DFFDA6B0B1aF3524018a1eE2E608785F7

    • Add DssBlow2 to the Chainlog

      • Add DssBlow2 to the Chainlog as MCD_BLOW2 at 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79

    • Spark Proxy Spell

      • Trigger Spark Proxy Spell at 0xBeA5FA2bFC4F6a0b6060Eb8EC23F25db8259cEE0
  • Office hours value in the Exec Doc matches the spell
  • Sum of all payments in the Exec Doc matches the tests
  • Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
  • Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
  • Every action present in the spell code is present in the Exec Doc
  • Every action in the Exec Doc is present in the spell code
• IF new commits are present in the spell
  • Copy relevant checklist items from the above and redo them
  • Ensure newly added code is covered by tests
  • Check if chainlog needs to be updated
  • Copy over and redo "Tests" section from the above
• IF all checks pass, make sure to include explicit "Good to deploy" comment

[SidestreamBurningBanana]

Good to deploy

Mainnet Executive Spell Review Checklist

Development Stage

• Install stable Foundry version
  • Find the first Foundry release that is older than 7 days from now
    • Insert the release URL here:
      ℹ️ https://github.com/foundry-rs/foundry/releases/tag/nightly-4974a0891bf01511993f49138ebf81f4be207cdf
  • Install the specified version via foundryup --version git_tag_name

    Document the installation logs containing installed versions below:
    foundryup: use - forge 1.0.0-dev (4974a0891b 2025-03-04T16:07:19.696344788Z)
    foundryup: use - cast 1.0.0-dev (4974a0891b 2025-03-04T16:07:19.696344788Z)
    foundryup: use - anvil 1.0.0-dev (4974a0891b 2025-03-04T16:07:19.696344788Z)
    foundryup: use - chisel 1.0.0-dev (4974a0891b 2025-03-04T16:07:19.696344788Z)
    

• Preparation
  • Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet
    https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit?gid=1558518178#gid=1558518178
  • Using Exec Sheet URL from the above, read spell instructions from the Exec Sheet and list them below

    • Init Nova Allocator Instance

      • Rename chainlog key PIP_ALLOCATOR_SPARK_A into PIP_ALLOCATOR
      • Init new Allocator instance by calling AllocatorInit.initIlk with:
        • sharedInstance.oracle: PIP_ALLOCATOR from chainlog
        • sharedInstance.roles: ALLOCATOR_ROLES from chainlog
        • sharedInstance.registry: ALLOCATOR_REGISTRY from chainlog
        • ilkInstance.owner: MCD_PAUSE_PROXY from chainlog
        • ilkInstance.vault: 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77
        • ilkInstance.buffer: 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c
        • cfg.ilk: ALLOCATOR-NOVA-A
        • cfg.duty: 0%
        • cfg.gap: 1 million
        • cfg.maxLine: 60 million
        • cfg.ttl: 20 hours
        • cfg.allocatorProxy: MCD_PAUSE_PROXY from chainlog
        • cfg.ilkRegistry: ILK_REGISTRY from chainlog
      • Remove newly created PIP_ALLOCATOR_NOVA_A from chainlog
      • Approve Operator to transfer USDS out of the AllocatorBuffer with:
        • address asset: USDS from chainlog
        • address spender: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint256 amount: type(uint256).max
      • Allow Operator to call “draw” and “wipe” functions using ALLOCATOR_ROLES, with:
        • bytes32 ilk: ALLOCATOR-NOVA-A
        • address who: 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54
        • uint8 role: 0
        • bool enabled: true
      • Add ALLOCATOR-NOVA-A ilk to the LINE_MOM

    • Smart Burn Engine Parameter Update

      • Increase hop for 1284 seconds, from 876 seconds to 2160 seconds

    • Rates Changes

      • Increase ALLOCATOR-SPARK-A Stability Fee by 0.52 percentage points from 3.22% to 3.74%
      • Increase DSR by 0.75 percentage points from 4.75% to 5.50%

    • Launch Project Funding

      • Transfer 5,000,000 USDS to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F
      • Transfer 9,600,000 SKY to 0x3C5142F28567E6a0F172fd0BaaF1f2847f49D02F

    • Top-up of the Integration Boost

      • Integration Boost - 3,000,000 USDS - 0xD6891d1DFFDA6B0B1aF3524018a1eE2E608785F7

    • Add DssBlow2 to the Chainlog

      • Add DssBlow2 to the Chainlog as MCD_BLOW2 at 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79

    • Spark Proxy Spell

      • Trigger Spark Proxy Spell at 0xBeA5FA2bFC4F6a0b6060Eb8EC23F25db8259cEE0
• Base checks
  • Current solc version 0.8.16
  • Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • Office hours value matches the Exec Sheet
  • 30 days spell expiry set in the constructor (block.timestamp + 30 days)
• Spell description
  • Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • TARGET_DATE in the description matches the target date
  • Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
• Comments inside the spell
  • Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • Every Instruction text have newline above it
    ℹ️ This rule was amended to accommodate with: instructions
  • IF an instruction can not be taken, it should have explanation under the instruction prefixed with // Note: (e.g.: // Note: Payments are skipped on goerli)
  • IF action in the spell doesn't have relevant instruction (e.g.: chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
    • // Executive Vote: if URL starts with https://vote.makerdao.com/executive/
    • // Poll: if URL starts with https://vote.makerdao.com/polling/
    • // Forum: if URL starts with https://forum.makerdao.com/t/
    • // MIP: if URL starts with https://mips.makerdao.com/mips/details/
• Dependency checks
  • Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out 'a8a7b151c39282d4ddab8cb4ead2d80342df588f'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out '978ac6fadb62f5f0b723c996f64be52eddba6801'

  • IF submodule upgrades are present, make sure dss-exec-lib is synced as well
  • git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
    ℹ️ We are using the latest commit, there has been no critical changes since then
  • dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test
• IF interfaces are present in the spell
  • Interfaces imported from dss-interfaces
    • No unused dss-interfaces
    • Only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
  • Static Interfaces
    • No unused static interfaces
    • Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
    • Interface matches deployed contract using cast interface <contract_address> command
    • Interface naming style should match with Like suffix (e.g. VatLike)
      • EXCEPTION: known interface naming exceptions
    • Each static interface declare only functions actually used in the spell code
• IF variable declarations are present in the spell
  • IF precision units are present
    • Precision units used in the spell match their defined values:
      • WAD = 10 ** 18
      • RAY = 10 ** 27
      • RAD = 10 ** 45
    • Precision units match with Numerical Ranges
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF math units are present
    • Match their defined values:
      • HUNDRED = 10 ** 2
      • THOUSAND = 10 ** 3
      • MILLION = 10 ** 6
      • BILLION = 10 ** 9
    • Match with config
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
  • IF rates are present
    • Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Rates match IPFS document
    • Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
    • Rate variable visibility declared as internal
    • Rate variable state mutability declared as constant
  • IF timestamps are present
    • Comment above timestamp states full date including UTC timezone
    • Timestamp converts back to the correct date
    • Timestamp converts back to the UTC timezone
    • Variable naming matches MMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)
    • Time of day makes logical sense in the context of timestamp usage (i.e. 23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)
    • Each variable visibility is declared as internal
    • Each variable state mutability is declared as constant
• IF new contract is present in the spell (not yet on chainlog or new to chainlog)
  • DssBlow2 Source, Audit
    • Source code is verified on etherscan
      ℹ️ 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79
    • Compilation optimizations match deployment settings defined in the source code repo
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      ℹ️ Items checked: daiJoin_ matches MCD_JOIN_DAI, usdsJoin_ matches USDS_JOIN, vow_ matches MCD_VOW
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure that there are no other Rely events except for PAUSE_PROXY (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
    • Deployer address is included into addresses_deployers.sol
      ℹ️ Dewiz at 0xa44E7F0cEfbdA0aEb5fdf6228acA9b9F069CC1F1
  • AllocatorVault Source, Audit
    • Source code is verified on etherscan
      ℹ️ 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77
    • Compilation optimizations match deployment settings defined in the source code repo
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      ℹ️ Items checked: roles_ matches ALLOCATOR_ROLES, buffer_ matches ALLOCATOR_NOVA_A_BUFFER, ilk_ is ALLOCATOR-NOVA-A, usdsJoin_ matches USDS_JOIN
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure that there are no other Rely events except for PAUSE_PROXY (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
    • Deployer address is included into addresses_deployers.sol
  • AllocatorBuffer Source, Audit
    • Source code is verified on etherscan
      ℹ️ 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c
    • Compilation optimizations match deployment settings defined in the source code repo
    • GNU AGPLv3 license
    • Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
      ℹ️ No constructor
    • IF new contract have concept of wards or access control
      • Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
      • Ensure that contract deployer address was denied (wards(deployer) is 0)
      • Ensure that there are no other Rely events except for PAUSE_PROXY (using a block explorer like etherscan)
    • Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
    • Deployer address is included into addresses_deployers.sol
• IF core system parameter changes are present in the instructions
  • IF stability fee (jug.ilk.duty) is updated
    • (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
    • Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
    • (DssExecLib.setDSR(rate, doDrip)) is used
    • Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
    • Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • Double check that rate match IPFS document
  • IF spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is used
  • IF dog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
  • IF vat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is used
  • IF dog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is used
  • IF clip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is used
  • IF clipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is used
  • IF clip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is used
  • IF clip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is used
  • IF clip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is used
  • IF clip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is used
  • IF calc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is used
  • IF calc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is used
• IF debt ceiling changes are present in the instructions
  • IF adjusted collateral type (ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)
    • IF collateral debt ceiling requested to be 0
      • Collateral is removed from AutoLine (MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)
      • The instruction to remove from AutoLine (MCD_IAM_AUTO_LINE) is present in the Exec Sheet
      • Collateral debt ceiling is set to 0 via DssExecLib.setIlkDebtCeiling(ilk, amount)
      • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to
    • IF AutoLine parameters are updated
      ℹ️ Updated in AllocatorInit, uses AutoLine.setIlk correctly, same as DssExecLib
      • EITHER is used, depending on the instruction:
        • DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
        • DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
  • IF collateral debt ceiling (vat.ilk.line) is updated
    • Collateral type (ilk) have AutoLine disabled previously or in the spell
      ℹ️ AutoLine is being enabled as part of AllocatorInit simultaneously with setting line value to cfg.gap: 1 million. Next checklist items are satisfied by AllocatorInit itself.
    • EITHER is used, depending on the instruction:
      • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.setIlkDebtCeiling(ilk, amount)
    • Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
      • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
      • DssExecLib.setGlobalDebtCeiling(amount)
      • DssExecLib.increaseGlobalDebtCeiling(amount)
      • DssExecLib.decreaseGlobalDebtCeiling(amount)
• IF additional dependencies (i.e. ./src/dependencies/ directory) are present:
  • IF the dependencies contracts/libraries have been audited
    ℹ️ dss-allocator/deploy/AllocatorInit.sol, dss-allocator/deploy/AllocatorInstances.sol
    • Each contract/library exactly matches (i.e. diff check) the source code of the latest audited version
  • OTHERWISE obtain the permalink to the relevant repository from a trusted party (i.e. Gov Facilitators)
    • Each contract/library exactly matches (i.e. diff check) the source code from the permalink
• IF onboarding is present
  • Insert and follow the relevant checklists below:
    • Collateral Onboarding
      ⚠️ Checks do not apply here as it is not a regular collateral
    • RWA Onboarding
    • Teleport Onboarding
• IF PSM migration, onboarding or offboarding is present:
  • Insert and follow the relevant checklists below:
    • PSM Checklists
• IF D3M onboarding is present, insert and follow D3M Checklist
• IF crypto collateral offboarding is present in the spell
  • 1st stage collateral offboarding
    • Collateral type (ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabled
    • Collateral debt ceiling (vat.ilk.line) is set to 0
    • Global debt ceiling (vat.Line) decreased by the total amount of offboarded ilks
  • 2nd stage collateral offboarding
    • All actions from the 1st stage offboarding are previously taken (EITHER in the current or past spells – check the archive)
    • Collateral liquidation penalty (chop) is set to 0 IF requested by governance
    • Flat keeper incentive (tip) is set to 0 IF requested by governance
    • Relative keeper incentive (chip) is set to 0 IF requested by governance
    • Max liquidation amount (hole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governance
    • Relevant clipper contract (MCD_CLIP_) is active (i.e. stopped is 0)
    • Liquidations are triggered via (depending on governance instruction):
      • EITHER liquidation ratio (spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))
      • OR via enabling linear interpolation (DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))
        • Ensure name format matches "XXX-X Offboarding"
        • Ensure target matches DssExecLib.spotter() address
        • Ensure ilk format matches collateral type (ilk) name ("XXX-X")
        • Ensure what matches string "mat"
        • Ensure startTime matches block.timestamp
        • Ensure start uses variable CURRENT_XXX_A_MAT
        • Ensure start matches current spotter.ilk.mat value
        • Ensure end uses variable TARGET_XXX_A_MAT
        • Ensure end value matches the instruction
        • Ensure end allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)
        • Ensure duration matches the instruction
    • Spotter price is updated via DssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)
    • Spotter price is updated after all other actions
    • Offboarding is tested at least via _checkIlkClipper helper
• IF RWA updates are present
  • Insert and follow the relevant checklists below:
    • RWA Update
• IF RWA offboardings are present
  • Insert and follow the relevant checklists below:
    • RWA Offboarding
• IF payments are present in the spell
  • IF MKR transfers are present
    ℹ️ SKY payments are checked instead
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • Transfer amount is specified with (at least) 2 decimals using ether keyword
      ℹ️ transferSky does not accept decimals
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • The transfers are tested via testMKRPayments test
      ⚠️ testMKRPayments is not in the tests, testPayments is used instead
    • Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Sheet
  • IF DAI surplus buffer transfers are present
    ℹ️ USDS payments are checked instead
    • Recipient address in the instruction is in the checksummed format
    • Recipient address matches Exec Sheet
    • Recipient address variable name matches one found in addresses_wallets.sol
    • Transfer amount matches Exec Sheet
    • The transfers are tested via testDAIPayments test
      ⚠️ testDAIPayments is not in the tests, testPayments is used instead
    • Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Sheet
  • IF MKR or DAI streams (DssVest) are created
    • VestAbstract interface is imported from dss-interfaces/dss/VestAbstract.sol
    • restrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Sheet
    • usr (Vest recipient address) matches Exec Sheet
    • usr address in the instruction is in the checksummed format
    • usr address variable name match one found in addresses_wallets.sol
    • tot (Total stream amount) matches Exec Sheet
    • IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
    • IF vest amount is expressed in 'per year' or similar in the Exec Sheet, account for leap days
    • bgn (Vest start timestamp) matches Exec Sheet
    • tau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • fin (Vest end timestamp) matches Exec Sheet
    • eta (Vest cliff duration) matches the following logic
      • IF eta is explicitly specified in the Exec Sheet, then the values match
      • IF eta and clf (Cliff end timestamp) are not specified in the Exec Sheet, then eta is 0
      • IF clf is specified, but clf <= bgn, then eta is 0
      • IF clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • IF mgr (Vest manager address) is specified in the Exec Sheet, matches the value, OTHERWISE matches address(0)
    • Ensure that max vesting rate (cap) is enough for the new streams
      • The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
      • The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
      • Calculate new cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
    • IF max vesting rate (cap) is changed in the spell
      • Governance facilitators were notified
      • Exec Sheet contain explicit instruction
      • Exec Sheet contain explicit instruction
    • IF MKR stream (DssVestTransferrable) is present
      • Vest contract's MKR allowance increased by the cumulative total (the sum of all tot values)
      • Ensure allowance increase follows archive patterns
    • Tested via testVestDAI or testVestMKR
  • IF MKR or DAI vest termination (Yank) is present
    • Yanked stream ID matches Exec Sheet
    • MCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yank
    • MCD_VEST_DAI chainlog address is used for DAI stream yank
    • Tested via testYankDAI or testYankMKR
• IF SubDAO-related content is present
  • IF SubDAO provides SubProxy spell address
    • SubDAO spell address matches Exec Sheet
    • Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
    • Execution is NOT delegate call
    • IF SubDAO spell deployer is a smart contract (e.g. multisig or factory), ensure the deployer address is in addresses_deployers.sol as an entry
      ℹ️ 0xd1236a6A111879d9862f8374BA15344b6B233Fbd, // Phoenix Labs from 2023-05-24
    • Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts
  • IF SubDAO provides instructions to be executed by the main spell (i.e. that will operate within Pause Proxy DelegateCall context)
    • No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
    • SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
    • SubDAO contracts and all libraries / dependencies have verified source code (Blocking)
    • Upgradable SubDAO contracts
      • Upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
      • Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
    • All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Sheet and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Sheet. SubDAO addresses being called must be confirmed by the SubDAO spell team.
    • IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
    • SubDAO actions match Exec Sheet (only where inline with main spell code) and do not affect core contracts
    • Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
    • External calls for SubDAO content are NOT delegate call
    • Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
• IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
  • Target Contract doesn't block spell execution
  • External call is NOT delegatecall
  • Target Contract doesn't have permissions on the Vat
  • Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • MCD Pause Proxy doesn't give any approvals
  • All possible actions of the Target Contract are documented
  • Target contract is not upgradable
  • Target Contract is included in the ChainLog
  • Test Coverage is comprehensive
• IF spell interacts with ChainLog
  • ChainLog version is incremented based on update type
    • Major -> New Vat (++.0.0)
    • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
    • Patch -> Collateral addition or addition/modification (0.0.++)
  • New addresses are added to the addresses_mainnet.sol
  • Changes are tested via testChainlogIntegrity and testChainlogValues
• Ensure every spell variable is declared as public/internal
• Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
  • Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)
    ⚠️ This is not true for PIP_ALLOCATOR. The variable name better suits sharedInstance.oracle: PIP_ALLOCATOR from chainlog instruction, however.
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    ℹ️ ad72002
  • Ensure every test function is declared as public
    • IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • Ensure each spell action has sufficient test coverage
    • Nova Allocator Instance:
      • Rename chainlog key - testAddChainlogKeys, testRemoveChainlogValues
      • Init new Allocator - testAllocatorIntegration
      • Remove newly created PIP_ALLOCATOR_NOVA_A from chainlog - testAddChainlogKeys
      • Approve Operator to transfer USDS - testAllocatorIntegration
      • Allow Operator to call “draw” and “wipe” - testAllocatorIntegration
      • Add ALLOCATOR-NOVA-A ilk to the LINE_MOM - testNewLineMomIlks
    • SBE Parameter update - testGeneral
    • Rates Changes - testGeneral
    • Launch Project Funding - testPayments
    • Integration Boost - testPayments
    • Add DssBlow2 to the Chainlog - testAddChainlogKeys, testChainlogValues
    • Spark Proxy Spell - testSparkSpellIsExecuted
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • IF a new module is initialized via the spell, the tests must include
    • Sanity checks of the constructor arguments
    • Sanity checks of all values added/updated by the spell function
    • End-to-end "happy path" interaction with the module
  • Check all tests are passing locally using make test
    • Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠘] Compiling 4 files with Solc 0.8.16
[⠃] Solc 0.8.16 finished in 1.71s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2421967)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 10.93s (9.43s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  revertTo(uint256): replaced by `revertToState`
  snapshot(): replaced by `snapshotState`
Ran 43 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAddChainlogKeys() (gas: 2348357)
[PASS] testAllocatorIntegration() (gas: 2630544)
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 2254775)
[PASS] testCastOnTime() (gas: 2250525)
[PASS] testChainlogIntegrity() (gas: 7869903)
[PASS] testChainlogValues() (gas: 12321290)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 15832)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 4696478)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34992989)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 3264270)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNewLineMomIlks() (gas: 2260799)
[PASS] testNextCastTime() (gas: 458207)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 497350)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 3585464)
[PASS] testPayments() (gas: 2376560)
[PASS] testRemoveChainlogValues() (gas: 2259456)
[PASS] testRevertIfNotScheduled() (gas: 17596)
[PASS] testSparkSpellIsExecuted() (gas: 2256484)
[PASS] testSplitter() (gas: 2754645)
[PASS] testSystemTokens() (gas: 3470975)
[PASS] testUseEta() (gas: 354708)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 21 passed; 0 failed; 22 skipped; finished in 82.50s (262.54s CPU time)

Ran 2 test suites in 82.70s (93.43s CPU time): 23 tests passed, 0 failed, 22 skipped (45 total tests)

Pre-Deployment Stage

• Wait till the Exec Doc is merged

• Exec Doc checks

  • Exec Doc for the specified date is found in the makerdao/community GitHub repo
  • Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • Extract permanent URL to the raw markdown file and paste it below
    ℹ️ https://raw.githubusercontent.com/makerdao/community/878d6d6f39c0fec5ff53e9f05a99e8e60f0fb7d4/governance/votes/Executive%20vote%20-%20March%206%2C%202025.md
  • Ensure the URL uses commit hash that introduced last change to the Exec Doc, NOT merge commit
    • IF there is no local copy of makerdao/community GitHub repo), run:

      git clone https://github.com/makerdao/community
      

    • OTHERWISE, ensure it is pointing to the latest commit on master:

      git switch master && git pull origin master
      

    • Get the latest commit hash for the exec doc:

      git log --pretty=oneline -1 -- "<LOCAL_PATH_TO_EXEC_DOC>"
      

  • Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
    ℹ️ 0x41dccf735863cd3893322b6f61651b8e518761705326dcae95d5fe882ec47655
  • Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
    ℹ️ 0x41dccf735863cd3893322b6f61651b8e518761705326dcae95d5fe882ec47655
  • Make sure that hash above doesn't match keccak hash of the empty string (0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470)
  • Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below
    • Common Spell Params
      • Office Hours: Yes
      • Global Line Modifier: No
        ⚠️ Not explicitly mentioned, but expected due to the new allocator onboarding
      • Order Of Operations Issues: No
    • ALLOCATOR-NOVA-A will be initialized as described below
      • Chainlog key PIP_ALLOCATOR_SPARK_A will be renamed to PIP_ALLOCATOR
      • AllocatorInit.initilk will be called with the following parameters:
        • sharedInstance.oracle - PIP_ALLOCATOR from the Chainlog.
        • sharedInstance.roles - ALLOCATOR_ROLES from the Chainlog.
        • sharedInstance.registry - ALLOCATOR-REGISTRY from the Chainlog.
        • ilkInstance.owner - MCD_PAUSE_PROXY from the Chainlog.
        • ilkInstance.vault - 0xe4470DD3158F7A905cDeA07260551F72d4bB0e77 (the newly deployed Allocator Vault).
        • ilkInstance.buffer - 0x065E5De3D3A08c9d14BF79Ce5A6d3D0E8794640c (the newly deployed Allocator Buffer).
        • cfg.ilk - ALLOCATOR_NOVA_A.
        • cfg.duty - 0.
        • cfg.gap - 1 million USDS.
        • cfg.maxLine - 60 million USDS.
        • cfg.ttl - 20 hours.
        • cfg.allocatorProxy - MCD_PAUSE_PROXY from the Chainlog.
        • cfg.ilkRegistry - ILK_REGISTRY from the Chainlog.
      • A new vault called ALLOCATOR-NOVA-A will be created with the following parameters:
        • Stability Fee - 0%.
        • Maximum Debt Ceiling (line) - 60 million USDS.
        • Target Available Debt (gap) - 1 million USDS.
        • Ceiling Increase Cooldown (ttl) - 20 hours.
      • The newly created PIP_ALLOCATOR_NOVA_A key will be removed from the Chainlog.
      • The operator address at 0x0f72935f6de6C54Ce8056FD040d4Ddb012B7cd54 will be approved to transfer USDS out of the Allocator Buffer by calling:
        BufferLike(ALLOCATOR_NOVA_A_BUFFER).approve(USDS, NOVA_OPERATOR, type(uint256).max);
      • ALLOCATOR-NOVA-A will be added to the LineMom.
    • The Smart Burn Engine hop parameter will be updated as described below.
      • Increase the hop parameter by 1,284 seconds from 876 seconds to 2,160 seconds.
    • Multiple rate changes will be made as described below.
      • Increase ALLOCATOR-SPARK-A Stability Fee by 0.52 percentage points from 3.22% to 3.74%.
      • Increase the DAI Savings Rate (DSR) by 0.75 percentage points from 4.75% to 5.50%.
    • 5 million USDS and 9.6 million SKY will be distributed to the Launch Project.
    • 3 million USDS for Integration Boost funding will be transferred to 0xD6891d1DFFDA6B0B1aF3524018a1eE2E608785F7.
    • DssBlow2 contract deployed at 0x81EFc7Dd25241acd8E5620F177E42F4857A02B79 will be added to the Chainlog as MCD_BLOW2.
    • A Spark proxy spell at 0xBeA5FA2bFC4F6a0b6060Eb8EC23F25db8259cEE0 will be triggered.

• Office hours value in the Exec Doc matches the spell

  • Sum of all payments in the Exec Doc matches the tests
  • Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
  • Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
  • Every action present in the spell code is present in the Exec Doc
  • Every action in the Exec Doc is present in the spell code

• IF new commits are present in the spell

  • Copy relevant checklist items from the above and redo them
  • Ensure newly added code is covered by tests
  • Check if chainlog needs to be updated
  • Copy over and redo "Tests" section from the above

• IF all checks pass, make sure to include explicit "Good to deploy" comment

[0xp3th1um]

• Spell deployed to 0x01cEBd4B43F3b4b03fd4E2a2c8ccc2303D4c4A9D
• Tenderly Virtual Testnet: https://dashboard.tenderly.co/explorer/vnet/eb97d953-4642-4778-938e-d70ee25e3f58
• Foundry installation logs:

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

 ╔═╗ ╔═╗ ╦ ╦ ╔╗╔ ╔╦╗ ╦═╗ ╦ ╦         Portable and modular toolkit
 ╠╣  ║ ║ ║ ║ ║║║  ║║ ╠╦╝ ╚╦╝    for Ethereum Application Development
 ╚   ╚═╝ ╚═╝ ╝╚╝ ═╩╝ ╩╚═  ╩                 written in Rust.

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

Repo       : https://github.com/foundry-rs/
Book       : https://book.getfoundry.sh/
Chat       : https://t.me/foundry_rs/
Support    : https://t.me/foundry_support/
Contribute : https://github.com/orgs/foundry-rs/projects/2/

.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx.xOx

foundryup: installing foundry (version stable, tag stable)
foundryup: downloading latest forge, cast, anvil, and chisel
#################################################################################################################################################### 100.0%
foundryup: downloading manpages
#################################################################################################################################################### 100.0%
foundryup: installed - forge Version: 1.0.0-stable
Commit SHA: e144b82070619b6e10485c38734b4d4d45aebe04
Build Timestamp: 2025-02-13T20:02:56.515812000Z (1739476976)
Build Profile: maxperf
foundryup: installed - cast Version: 1.0.0-stable
Commit SHA: e144b82070619b6e10485c38734b4d4d45aebe04
Build Timestamp: 2025-02-13T20:02:56.515812000Z (1739476976)
Build Profile: maxperf
foundryup: installed - anvil Version: 1.0.0-stable
Commit SHA: e144b82070619b6e10485c38734b4d4d45aebe04
Build Timestamp: 2025-02-13T20:02:56.515812000Z (1739476976)
Build Profile: maxperf
foundryup: installed - chisel Version: 1.0.0-stable
Commit SHA: e144b82070619b6e10485c38734b4d4d45aebe04
Build Timestamp: 2025-02-13T20:02:56.515812000Z (1739476976)
Build Profile: maxperf
foundryup: done

[0xdecr1pto]

Good to handover

Deployed Stage

• Crafter's comment in the PR
  • Contains relevant Foundry installation logs
  • Contains a URL to the deployed spell
    • URL matches the spell address declared in config.sol
  • Contains a URL to the Tenderly Testnet
• Source code settings
  • Deployed spell is verified on etherscan
  • Optimization enabled: false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failed
  • Default evmVersion
  • GNU AGPLv3 license
• Source code validity
  • Deployed spell code matches source on github. (can be checked via make diff-deployed-spell or manually)
  • No new changes are made after previously given "good to deploy"
• Deployed spell Etherscan checks
  • Automated checks via make check-deployed-spell
    Doesn't work, all checked manually
    • Verified
    • Valid license
    • Version matches
    • Optimizations are disabled
    • dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • deployed_spell_created matches deployment timestamp
    • deployed_spell_block matches deployment block number
  • Manual checks
    • Ensure make deploy-info tx=<tx> matches config
      • deployed_spell_created timestamp
      • deployed_spell_block block number
    • Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
    • Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
      Hash doesn't match as an previouse spell, not critical
• Tenderly Testnet checks
  • A testnet with the name matching spell description is found at maker dashboard
  • The testnet name is unique (previous testnets does not have the same name)
  • Cast transaction is set to the correct "receiver" (matches deployed spell address)
  • All actions are executed in the transaction trace
  • No reverts are present that block execution
    Spark spell is reverting
  • No out-of-gas errors are present
• Archive checks
  • make diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"
  • Ensure date corresponds to target Exec Doc date
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    Insert most recent commit hash where CI was passing
    37e1fe3
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test

[⠊] Compiling...
[⠆] Compiling 4 files with Solc 0.8.16
[⠰] Solc 0.8.16 finished in 2.32s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2422259)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 20.95s (19.71s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  revertTo(uint256): replaced by `revertToState`
  snapshot(): replaced by `snapshotState`
Ran 43 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAddChainlogKeys() (gas: 2348649)
[PASS] testAllocatorIntegration() (gas: 2630836)
[PASS] testBytecodeMatches() (gas: 4721468)
[PASS] testCastCost() (gas: 2255067)
[PASS] testCastOnTime() (gas: 2250817)
[PASS] testChainlogIntegrity() (gas: 7870195)
[PASS] testChainlogValues() (gas: 12321582)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34995378)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 3307510)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNewLineMomIlks() (gas: 2261091)
[PASS] testNextCastTime() (gas: 458207)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 497350)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 3585697)
[PASS] testPayments() (gas: 2376852)
[PASS] testRemoveChainlogValues() (gas: 2259748)
[PASS] testRevertIfNotScheduled() (gas: 17596)
[PASS] testSparkSpellIsExecuted() (gas: 2256776)
[PASS] testSplitter() (gas: 2754937)
[PASS] testSystemTokens() (gas: 3471164)
[PASS] testUseEta() (gas: 354708)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 20 passed; 0 failed; 23 skipped; finished in 175.75s (523.04s CPU time)

Ran 2 test suites in 176.09s (196.69s CPU time): 22 tests passed, 0 failed, 23 skipped (45 total tests)

[SidestreamBurningBanana]

Good to handover

Deployed Stage

• Crafter's comment in the PR
  • Contains relevant Foundry installation logs
  • Contains a URL to the deployed spell
    • URL matches the spell address declared in config.sol
  • Contains a URL to the Tenderly Testnet
• Source code settings
  • Deployed spell is verified on etherscan
  • Optimization enabled: false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failed
  • Default evmVersion
  • GNU AGPLv3 license
• Source code validity
  • Deployed spell code matches source on github. (can be checked via make diff-deployed-spell or manually)
  • No new changes are made after previously given "good to deploy"
• Deployed spell Etherscan checks
  • Automated checks via make check-deployed-spell
    • Verified
    • Valid license
    • Version matches
    • Optimizations are disabled
    • dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • deployed_spell_created matches deployment timestamp
    • deployed_spell_block matches deployment block number
  • Manual checks
    • Ensure make deploy-info tx=<tx> matches config
      • deployed_spell_created timestamp
      • deployed_spell_block block number
    • Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
    • Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
      ⚠️ We are using a more recent commit, as in the previous spells. The diff can be checked here: https://github.com/makerdao/dss-exec-lib/compare/v0.0.9..69b658f
• Tenderly Testnet checks
  • A testnet with the name matching spell description is found at maker dashboard
  • The testnet name is unique (previous testnets does not have the same name)
  • Cast transaction is set to the correct "receiver" (matches deployed spell address)
    ℹ️ Transaction
  • All actions are executed in the transaction trace
  • No reverts are present that block execution
    ⚠️ SubProxy revert is present. It is expected and confirmed by Spark to have no effect in production. The reason is that we are using EVM cheatcodes to warp time. It was also wrapped with a try/catch as a precaution.
  • No out-of-gas errors are present
• Archive checks
  • make diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"
  • Ensure date corresponds to target Exec Doc date
• Tests
  • Ensure that the DssExecLib.address file is not being modified by the spell PR
  • Check all CI tests are passing as at the latest commit
    ℹ️ 37e1fe3
  • Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • Check all tests are passing locally using make test

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠑] Compiling 4 files with Solc 0.8.16
[⠃] Solc 0.8.16 finished in 1.65s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2421972)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 8.91s (8.27s CPU time)

Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
  revertTo(uint256): replaced by `revertToState`
  snapshot(): replaced by `snapshotState`
Ran 43 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAddChainlogKeys() (gas: 2348362)
[PASS] testAllocatorIntegration() (gas: 2630549)
[PASS] testBytecodeMatches() (gas: 4721468)
[PASS] testCastCost() (gas: 2254780)
[PASS] testCastOnTime() (gas: 2250530)
[PASS] testChainlogIntegrity() (gas: 7869908)
[PASS] testChainlogValues() (gas: 12321295)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34995091)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 3307223)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNewLineMomIlks() (gas: 2260804)
[PASS] testNextCastTime() (gas: 458207)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 497350)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 3585468)
[PASS] testPayments() (gas: 2376565)
[PASS] testRemoveChainlogValues() (gas: 2259461)
[PASS] testRevertIfNotScheduled() (gas: 17596)
[PASS] testSparkSpellIsExecuted() (gas: 2256489)
[PASS] testSplitter() (gas: 2754650)
[PASS] testSystemTokens() (gas: 3470744)
[PASS] testUseEta() (gas: 354708)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[SKIP] testVestSKYmint() (gas: 0)
[SKIP] testVestUSDS() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 20 passed; 0 failed; 23 skipped; finished in 75.20s (237.73s CPU time)

Ran 2 test suites in 75.41s (84.11s CPU time): 22 tests passed, 0 failed, 23 skipped (45 total tests)

[SidestreamBurningBanana]

Handover and Merge Stage

• Check that the spell address posted by the crafter in new-spells is correct
• Confirm the address in the new-spells channel (via a separate "reply to" message, restating the address to avoid edits)
  • Wait until responsible governance facilitator confirms handover in new-spells
• Ensure that no changes were made to the code since the spell was deployed and archived
• Approve spell PR for merge via 'Approve' review option

[0xdecr1pto]

Handover and Merge Stage

• Check that the spell address posted by the crafter in new-spells is correct
• Confirm the address in the new-spells channel (via a separate "reply to" message, restating the address to avoid edits)
  • Wait until responsible governance facilitator confirms handover in new-spells
• Ensure that no changes were made to the code since the spell was deployed and archived
• Approve spell PR for merge via 'Approve' review option