-
-
Notifications
You must be signed in to change notification settings - Fork 49
feat: Asset references, world.get_asset
and world.has_asset
bindings
#484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aggyomfg
wants to merge
8
commits into
makspll:main
Choose a base branch
from
aggyomfg:asset_operations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+280
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
makspll
reviewed
Oct 1, 2025
makspll
reviewed
Oct 1, 2025
makspll
reviewed
Oct 1, 2025
makspll
reviewed
Oct 1, 2025
world.get_asset
and world.has_asset
bindings
Nice work, much appreciated! @aggyomfg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for your creation! BMS is very useful engine!
This PR Potentially close #479
New Asset Reference Type: Added
ReflectBase::Asset(UntypedHandle, ComponentId)
Asset Creation Functions: Added
ReflectReference::new_asset_ref()
andReflectBaseType::new_asset_base()
Added two new
world
functions:get_asset(handle_reference, registration)
- Retrieves an asset by handlehas_asset(handle_reference)
- Checks if an asset existsTests, Docs + but didnt get what else needed, please ask.