Skip to content

FP for Gym interface #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

FP for Gym interface #134

wants to merge 10 commits into from

Conversation

mrkickling
Copy link
Contributor

@mrkickling mrkickling commented Jun 30, 2025 •
edited
Loading

  • Add code examples on how to use the different interfaces programmatically.
  • Implement false positives
  • Test the _generate_false_positives method
  • Test false positives actually being present in observations in the serialized obs env / gym envs

Branch made for Yacine - work in progress.

kasanari
kasanari reviewed Jun 30, 2025
View reviewed changes
@mrkickling mrkickling requested a review from AnserY June 30, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasanari kasanari kasanari left review comments

@AnserY AnserY Awaiting requested review from AnserY

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkickling @kasanari