Langgraph walkthrough - typehinting, docstringing and simplifications #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkickling
commented
May 30, 2025
|
|
||
| right_asset = self.assets[association['rightAsset']] | ||
| if not right_asset: |
There was a problem hiding this comment.
This would never happen before, the program would crash on a keyerror on the line before, so this if statement had to be changed.
mrkickling
commented
May 30, 2025
mrkickling
force-pushed
the
langgraph-walkthrough
branch
from
fcb2236 to
68c61b2
Compare
mrkickling
commented
Jun 26, 2025
maltoolbox/language/languagegraph.py
Outdated
| @@ -49,6 +49,7 @@ def to_dict(self) -> dict: | |||
|
|
|||
|
|
|||
| class Context(dict): | |||
| """TODO: What is a context?""" | |||
There was a problem hiding this comment.
Need you here @andrewbwm
mrkickling
force-pushed
the
langgraph-walkthrough
branch
from
ba4761c to
0e385f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is me walking through the Language Graph and changing things the linter tells me about and adding typehints.
I also added/altered docstrings and made some simplifications of small parts of the code.
I added a couple of TODO comments I want to fix before this merge, mostly for docstrings and 'type errors'.
Some mypy is failing now because I added typehinting and we need to abide by those, also TODO before merge.