Handle array query parameters in list converters#16
Merged
maltehuebner merged 2 commits intomainfrom Jan 27, 2026
Merged
Conversation
PHP parses query strings like ?param[]=a¶m[]=b as arrays. RequestToListConverter and ArrayToListConverter now join array values with comma before adding to RequestParameterList. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace TypeError expectations with assertions that verify correct string conversion of arrays, integers, floats, and booleans in list converters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
maltehuebner
force-pushed
the
fix-array-query-parameters
branch
from
76089b4 to
5370e5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrorwhen query parameters contain arrays (e.g.?param[]=a¶m[]=b)param[]=valueas an array, butRequestParameterList::add()only accepts stringsRequestToListConverterandArrayToListConverternow join array values with comma before adding toRequestParameterListProblem
Fix
Array values are joined with comma:
['a', 'b']becomes"a,b". Consumers can split on comma if they need to handle multiple values.🤖 Generated with Claude Code