ecoharmonogram_pl: return if sides_matcher is empty when creating entries in loop #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provider changed names of sides, and side, that it was trying to test no longer existed
fixes a logical error, where it loop over every side when side_matcher is not provided and it would return on first found side when side_matcher is provided that meant that if side_matcher didn't match against first found side, there would be no entries found
7 tasks
amozeo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a logical error, where it loop over every side when side_matcher is not provided and it would return on first found side when side_matcher is provided
that meant that if side_matcher didn't match against first found side,
there would be no entries found
one schedule provider in test cases also updated names for sides, so I updated this test accordingly